[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5201: inline: switch from inline to inline_function

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #5201:
URL: https://github.com/apache/incubator-nuttx/pull/5201#discussion_r781716665



##########
File path: include/nuttx/compiler.h
##########
@@ -200,11 +200,11 @@
 #    define __syslog__ __printf__
 #  endif
 
-#  define formatlike(a) __attribute__((__format_arg__ (a)))
-#  define printflike(a, b) __attribute__((__format__ (__printf__, a, b)))
-#  define sysloglike(a, b) __attribute__((__format__ (__syslog__, a, b)))
-#  define scanflike(a, b) __attribute__((__format__ (__scanf__, a, b)))
-#  define strftimelike(a) __attribute__((__format__ (__strftime__, a, 0)))
+#  define formatlike(a) __attribute__ ((__format_arg__ (a)))

Review comment:
       should we keep the old style(no space before '(')?

##########
File path: include/nuttx/compiler.h
##########
@@ -182,14 +182,14 @@
 #  if defined(__clang__)
 #    define nostackprotect_function __attribute__ ((optnone))
 #  else
-#    define nostackprotect_function __attribute__ ((__optimize__ ("-fno-stack-protector")))
+#    define nostackprotect_function __attribute__ ((optimize ("-fno-stack-protector")))

Review comment:
       remove the space before '('?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org