You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Lee Thompson (JIRA)" <ji...@codehaus.org> on 2009/05/03 15:36:45 UTC

[jira] Issue Comment Edited: (WAGON-264) compressed tarball download problems

    [ http://jira.codehaus.org/browse/WAGON-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=174980#action_174980 ] 

Lee Thompson edited comment on WAGON-264 at 5/3/09 8:34 AM:
------------------------------------------------------------

Looks like the client can not see the bypass behavior of mod_gzip.  If you run this little groovy program, it will dump the request headers...




URL url = new URL ( "http://prdownloads.sourceforge.net/expat/expat-1.98.8.tar.gz" );
HttpURLConnection urlConnection = (HttpURLConnection) url.openConnection();
urlConnection.setRequestProperty( "Accept-Encoding", "gzip" );
int responseCode = urlConnection.getResponseCode();
println "Response code is " + responseCode
Map<String, List<String>> hdrFields = urlConnection.getHeaderFields()
println hdrFields



output...


Response code is 200
[X-Powered-By:[PHP/5.2.8], Set-Cookie:[PHPSESSID=7f4eb0ee669a6363aa7c1e80b4980b0e; expires=Sunday, 17-May-09 13:23:42 GMT; path=/], X-SFX-Webhead:[sfs-web-7], null:[HTTP/1.1 200 OK], X-SFX-Revision:[release_20090417], Date:[Sun, 03 May 2009 13:23:42 GMT], Pragma:[no-cache], Content-type:[text/html], Cache-Control:[no-store, no-cache, must-revalidate, post-check=0, pre-check=0], Content-Encoding:[gzip], Expires:[Thu, 19 Nov 1981 08:52:00 GMT], Server:[lighttpd/1.4.19], Transfer-Encoding:[chunked], Vary:[Accept-Encoding, User-Agent]]




Suggest a "getCompressedFileExtension()" method to Resource.java which checks the file extenstion for common internet compressed file types like jar, zip, gz, tgz, bz2, mp3, etc.  If getCompressedFileExtension() is true, don't ask for the gzip encoding and don't check for it either.  This check would be needed for http and https.

      was (Author: stimpy):
    Looks like the client can not see the bypass behavior of mod_gzip.  If you run this little groovy program, it will dump the request headers...


URL url = new URL ( "http://prdownloads.sourceforge.net/expat/expat-1.98.8.tar.gz" );
HttpURLConnection urlConnection = (HttpURLConnection) url.openConnection();
urlConnection.setRequestProperty( "Accept-Encoding", "gzip" );
int responseCode = urlConnection.getResponseCode();
println "Response code is " + responseCode
Map<String, List<String>> hdrFields = urlConnection.getHeaderFields()
println hdrFields



output...


Response code is 200
[X-Powered-By:[PHP/5.2.8], Set-Cookie:[PHPSESSID=7f4eb0ee669a6363aa7c1e80b4980b0e; expires=Sunday, 17-May-09 13:23:42 GMT; path=/], X-SFX-Webhead:[sfs-web-7], null:[HTTP/1.1 200 OK], X-SFX-Revision:[release_20090417], Date:[Sun, 03 May 2009 13:23:42 GMT], Pragma:[no-cache], Content-type:[text/html], Cache-Control:[no-store, no-cache, must-revalidate, post-check=0, pre-check=0], Content-Encoding:[gzip], Expires:[Thu, 19 Nov 1981 08:52:00 GMT], Server:[lighttpd/1.4.19], Transfer-Encoding:[chunked], Vary:[Accept-Encoding, User-Agent]]




Suggest a "getCompressedFileExtension()" method to Resource.java which checks the file extenstion for common internet compressed file types like jar, zip, gz, tgz, bz2 and if getCompressedFileExtension() is true, don't as for the gzip encoding and don't check for it either.  This check would be needed fro http and https.
  
> compressed tarball download problems
> ------------------------------------
>
>                 Key: WAGON-264
>                 URL: http://jira.codehaus.org/browse/WAGON-264
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-http-lightweight
>    Affects Versions: 1.0-beta-2, 1.0-beta-3, 1.0-beta-4, 1.0-beta-5
>            Reporter: Lee Thompson
>
> HTTP wagon will uncompress tarballs it downloads, sometimes badly.  Downloading openssl results in an unpressed download
> $ mvn -X wagon:download-single -Dwagon.fromFile=openssl-0.9.8k.tar.gz -Dwagon.url=http://www.openssl.org/source -Dwagon.toDir=./
> $ tar tzf openssl-0.9.8k.tar.gz 
> gzip: stdin: not in gzip format
> tar: Child returned status 1
> tar: Error exit delayed from previous errors
> $ tar tf openssl-0.9.8k.tar.gz | more
> openssl-0.9.8k/apps/
> openssl-0.9.8k/apps/app_rand.c
> Downloading expat results in a corrupted file
> mvn -X wagon:download-single -Dwagon.fromFile=expat-1.98.8.tar.gz -Dwagon.url=http://prdownloads.sourceforge.net/expat -Dwagon.toDir=./
> $ tar tf expat-1.98.8.tar.gz 
> tar: This does not look like a tar archive
> tar: Skipping to next header
> tar: Read 1943 bytes from expat-1.98.8.tar.gz
> tar: Error exit delayed from previous errors

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira