You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AlenkaF (via GitHub)" <gi...@apache.org> on 2025/03/11 14:51:59 UTC
[PR] GH-45746: [C++] Remove deprecated functions in 20.0 (C++ subset) [arrow]
AlenkaF opened a new pull request, #45748:
URL: https://github.com/apache/arrow/pull/45748
### Rationale for this change
There are some deprecated C++ functions that can be removed.
### What changes are included in this PR?
This PR removes a subset of them. More precisely:
- `GetCapacity` in Gandiva cache.cc
- `BufferReader` constructors in io/memory.h
- `OpenAppendStream` in filesystem/gcsfs.h
- `owned_thread_pool_` in acero/exec_plan.cc
### Are these changes tested?
Current tests should pass.
### Are there any user-facing changes?
Deprecated functionality is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45746: [C++] Remove deprecated functions in 20.0 (C++ subset) [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #45748:
URL: https://github.com/apache/arrow/pull/45748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45746: [C++] Remove deprecated functions in 20.0 (C++ subset) [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #45748:
URL: https://github.com/apache/arrow/pull/45748#issuecomment-2769120763
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45746: [C++] Remove deprecated functions in 20.0 (C++ subset) [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #45748:
URL: https://github.com/apache/arrow/pull/45748#issuecomment-2763254687
I have removed the changes for [owned_thread_pool_](https://github.com/apache/arrow/blob/c124bb55d993daca93742ce896869ab3101dccbb/cpp/src/arrow/acero/exec_plan.cc#L343-L345) from this PR as I need to look into a segfault I get in a test that is using deprecated version of the `acero::ExecPlan::Make`. Plan to tackle this as part of https://github.com/apache/arrow/issues/45968.
Would be great to include this PR into 20.0.0 https://github.com/apache/arrow/issues/45680.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45746: [C++] Remove deprecated functions in 20.0 (C++ subset) [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45748:
URL: https://github.com/apache/arrow/pull/45748#issuecomment-2769129463
Revision: 798feb640bdd21004ddf787fa5de80bb2f2e4280
Submitted crossbow builds: [ursacomputing/crossbow @ actions-dfce518206](https://github.com/ursacomputing/crossbow/branches/all?query=actions-dfce518206)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/14195011169/job/39768031042)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/14195011216/job/39768031129)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/14195011341/job/39768032191)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14195010794/job/39768029636)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/14195010790/job/39768029364)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14195011516/job/39768032749)|
|test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14195011246/job/39768031595)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/14195010821/job/39768029864)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/14195011027/job/39768030753)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14195011583/job/39768032779)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/14195010816/job/39768029725)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14195011157/job/39768031142)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14195011239/job/39768031831)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/14195010742/job/39768029032)|
|test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14195011381/job/39768032340)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/14195011217/job/39768031550)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/14195010817/job/39768029993)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14195010939/job/39768030598)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/14195010863/job/39768030286)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14195011269/job/39768031934)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/14195010593/job/39768029012)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/14195010768/job/39768029251)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14195010853/job/39768030209)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45746: [C++] Remove deprecated functions in 20.0 (C++ subset) [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #45748:
URL: https://github.com/apache/arrow/pull/45748#issuecomment-2769252766
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45746: [C++] Remove deprecated functions in 20.0 (C++ subset) [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45748:
URL: https://github.com/apache/arrow/pull/45748#issuecomment-2769261211
Revision: 47b0ea33fa753c2ef53dd037b894615cdb056b88
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9d60b458c0](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9d60b458c0)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/14196082973/job/39771417360)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/14196084692/job/39771424284)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/14196083294/job/39771418973)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14196083011/job/39771417436)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/14196083770/job/39771420672)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14196084599/job/39771424340)|
|test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14196084162/job/39771422023)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/14196083556/job/39771420250)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/14196084468/job/39771423190)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14196083496/job/39771420069)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/14196083606/job/39771420205)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14196083993/job/39771421599)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14196083025/job/39771417563)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/14196084417/job/39771423083)|
|test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14196084548/job/39771423580)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/14196084545/job/39771423351)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/14196083188/job/39771418919)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14196083307/job/39771418953)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/14196082708/job/39771417511)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14196084207/job/39771422058)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/14196084245/job/39771422449)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/14196084226/job/39771422049)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14196083335/job/39771418967)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45746: [C++] Remove deprecated functions in 20.0 (C++ subset) [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #45748:
URL: https://github.com/apache/arrow/pull/45748#issuecomment-2770619027
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d73079d5a0bc8900ed81556b8cc4c3a5ee57d5a2.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/39802084324) has more details. It also includes information about 78 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org