You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/01/27 19:11:05 UTC
Review Request 42860: Add paths::sameParent to find out the same root
of a path list.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Joris Van Remoortere.
Bugs: MESOS-4521
https://issues.apache.org/jira/browse/MESOS-4521
Repository: mesos
Description
-------
Add paths::sameParent to find out the same root of a path list.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697
Diff: https://reviews.apache.org/r/42860/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 42860: Add paths::sameParent to find out the same
root of a path list.
Posted by haosdent huang <ha...@gmail.com>.
> On Jan. 27, 2016, 9:06 p.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 68
> > <https://reviews.apache.org/r/42860/diff/2/?file=1224085#file1224085line68>
> >
> > I am extremely confused about the expected semantics of this function (e.g. `EXPECT_SOME_EQ("/", path::sameParent({"/usr", "/", "/tmp"}));`?). I feel developing an intuition would be easier would this function take just two args (but am unsure); also, the name seems to suggest this returning some `bool` type which it doesn't.
> >
> > Looking at the implementation isn't too helpful either due to the complicated control flow. It should in principle be possible to simplify this by separating extracting path components and their comparisons, but am unsure if this is something we need for the intended use case from the follow-up patch.
>
> haosdent huang wrote:
> Thank you very much for your review. Do you mean change `sameParent` to other names here?
>
> Benjamin Bannier wrote:
> If you can, yes, but I am unsure this is a useful enough primitive for `path`s. You should find a shepherd and discuss this with him/her.
>
> I'd imagine that if you'd provide something to e.g. find a common prefix for a list of `path`s one might be able to reuse that functionality elsewhere; to get the functionality you need you could then check if that common prefix is already in the given list (that would be in your next patch, not here in stout).
oh, yes. I want implement a util funtion similar to os.path.commonprefix in python here.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/#review116606
-----------------------------------------------------------
On Jan. 28, 2016, 2:12 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42860/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 2:12 a.m.)
>
>
> Review request for mesos, Jie Yu and Joris Van Remoortere.
>
>
> Bugs: MESOS-4521
> https://issues.apache.org/jira/browse/MESOS-4521
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add paths::sameParent to find out the same root of a path list.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f
> 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697
>
> Diff: https://reviews.apache.org/r/42860/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42860: Add paths::sameParent to find out the same
root of a path list.
Posted by haosdent huang <ha...@gmail.com>.
> On Jan. 27, 2016, 9:06 p.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 68
> > <https://reviews.apache.org/r/42860/diff/2/?file=1224085#file1224085line68>
> >
> > I am extremely confused about the expected semantics of this function (e.g. `EXPECT_SOME_EQ("/", path::sameParent({"/usr", "/", "/tmp"}));`?). I feel developing an intuition would be easier would this function take just two args (but am unsure); also, the name seems to suggest this returning some `bool` type which it doesn't.
> >
> > Looking at the implementation isn't too helpful either due to the complicated control flow. It should in principle be possible to simplify this by separating extracting path components and their comparisons, but am unsure if this is something we need for the intended use case from the follow-up patch.
Thank you very much for your review. Do you mean change `sameParent` to other names here?
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/#review116606
-----------------------------------------------------------
On Jan. 27, 2016, 6:36 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42860/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 6:36 p.m.)
>
>
> Review request for mesos, Jie Yu and Joris Van Remoortere.
>
>
> Bugs: MESOS-4521
> https://issues.apache.org/jira/browse/MESOS-4521
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add paths::sameParent to find out the same root of a path list.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f
> 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697
>
> Diff: https://reviews.apache.org/r/42860/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42860: Add paths::sameParent to find out the same
root of a path list.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Jan. 27, 2016, 10:06 p.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 68
> > <https://reviews.apache.org/r/42860/diff/2/?file=1224085#file1224085line68>
> >
> > I am extremely confused about the expected semantics of this function (e.g. `EXPECT_SOME_EQ("/", path::sameParent({"/usr", "/", "/tmp"}));`?). I feel developing an intuition would be easier would this function take just two args (but am unsure); also, the name seems to suggest this returning some `bool` type which it doesn't.
> >
> > Looking at the implementation isn't too helpful either due to the complicated control flow. It should in principle be possible to simplify this by separating extracting path components and their comparisons, but am unsure if this is something we need for the intended use case from the follow-up patch.
>
> haosdent huang wrote:
> Thank you very much for your review. Do you mean change `sameParent` to other names here?
If you can, yes, but I am unsure this is a useful enough primitive for `path`s. You should find a shepherd and discuss this with him/her.
I'd imagine that if you'd provide something to e.g. find a common prefix for a list of `path`s one might be able to reuse that functionality elsewhere; to get the functionality you need you could then check if that common prefix is already in the given list (that would be in your next patch, not here in stout).
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/#review116606
-----------------------------------------------------------
On Jan. 28, 2016, 3:12 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42860/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 3:12 a.m.)
>
>
> Review request for mesos, Jie Yu and Joris Van Remoortere.
>
>
> Bugs: MESOS-4521
> https://issues.apache.org/jira/browse/MESOS-4521
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add paths::sameParent to find out the same root of a path list.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f
> 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697
>
> Diff: https://reviews.apache.org/r/42860/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42860: Add paths::sameParent to find out the same
root of a path list.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/#review116606
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 68)
<https://reviews.apache.org/r/42860/#comment177675>
I am extremely confused about the expected semantics of this function (e.g. `EXPECT_SOME_EQ("/", path::sameParent({"/usr", "/", "/tmp"}));`?). I feel developing an intuition would be easier would this function take just two args (but am unsure); also, the name seems to suggest this returning some `bool` type which it doesn't.
Looking at the implementation isn't too helpful either due to the complicated control flow. It should in principle be possible to simplify this by separating extracting path components and their comparisons, but am unsure if this is something we need for the intended use case from the follow-up patch.
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (lines 70 - 71)
<https://reviews.apache.org/r/42860/#comment177673>
These will dereference `paths.end()` if `paths` is empty (which in turn might do anything).
- Benjamin Bannier
On Jan. 27, 2016, 7:36 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42860/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 7:36 p.m.)
>
>
> Review request for mesos, Jie Yu and Joris Van Remoortere.
>
>
> Bugs: MESOS-4521
> https://issues.apache.org/jira/browse/MESOS-4521
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add paths::sameParent to find out the same root of a path list.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f
> 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697
>
> Diff: https://reviews.apache.org/r/42860/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42860: Add paths::overlapping to check whether
paths are overlapping.
Posted by haosdent huang <ha...@gmail.com>.
> On March 21, 2016, 5:29 p.m., Neil Conway wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 70
> > <https://reviews.apache.org/r/42860/diff/3/?file=1224521#file1224521line70>
> >
> > `if (paths.empty()) { ... }` seems like a clearer way to write this.
@neic, @bbannier Thank you for your detail reviews. I rework the patches, could you help review them again? Thanks a lot.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/#review124577
-----------------------------------------------------------
On March 29, 2016, 2:30 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42860/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 2:30 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-4521
> https://issues.apache.org/jira/browse/MESOS-4521
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add paths::overlapping to check whether paths are overlapping.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f
> 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697
>
> Diff: https://reviews.apache.org/r/42860/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42860: Add paths::sameParent to find out the same
root of a path list.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/#review124577
-----------------------------------------------------------
Given `{"/usr/lib", "/usr/lib64"}`, this returns "/usr/lib". Given `{"/usr-/xxx", "/usr", "/usr/baz"}`, this returns "/usr". Both seem incorrect.
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 68)
<https://reviews.apache.org/r/42860/#comment187196>
I agree with Benjamin: the semantics of this function are very unclear. At minimum it needs a header comment to identify what the function returns. I also don't think it should be called `sameParent` if it doesn't return a boolean/`Try<Nothing>`.
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 70)
<https://reviews.apache.org/r/42860/#comment187193>
`if (paths.empty()) { ... }` seems like a clearer way to write this.
- Neil Conway
On Jan. 28, 2016, 2:12 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42860/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 2:12 a.m.)
>
>
> Review request for mesos, Jie Yu and Joris Van Remoortere.
>
>
> Bugs: MESOS-4521
> https://issues.apache.org/jira/browse/MESOS-4521
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add paths::sameParent to find out the same root of a path list.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f
> 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697
>
> Diff: https://reviews.apache.org/r/42860/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42860: Add paths::overlapping to check whether
paths are overlapping.
Posted by haosdent huang <ha...@gmail.com>.
> On March 29, 2016, 3:30 a.m., Neil Conway wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 127
> > <https://reviews.apache.org/r/42860/diff/4/?file=1317602#file1317602line127>
> >
> > What does "flat" mean, here? Also, is it worth adding a `CHECK` that all paths are absolute?
`flat` means the path is not like "/a/../c" or "/a//b". Do you think we need add a method like `path::simplify()` to flat the path passed in?
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/#review125801
-----------------------------------------------------------
On March 29, 2016, 8:56 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42860/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 8:56 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-4521
> https://issues.apache.org/jira/browse/MESOS-4521
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add paths::overlapping to check whether paths are overlapping.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f
> 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697
>
> Diff: https://reviews.apache.org/r/42860/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42860: Add paths::overlapping to check whether
paths are overlapping.
Posted by haosdent huang <ha...@gmail.com>.
> On March 29, 2016, 3:30 a.m., Neil Conway wrote:
> > Made a few quick comments. I didn't look at the `CheckOverlapTree` logic itself yet though.
Thanks a lot! Let me update.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/#review125801
-----------------------------------------------------------
On March 29, 2016, 2:30 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42860/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 2:30 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-4521
> https://issues.apache.org/jira/browse/MESOS-4521
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add paths::overlapping to check whether paths are overlapping.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f
> 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697
>
> Diff: https://reviews.apache.org/r/42860/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42860: Add paths::overlapping to check whether
paths are overlapping.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/#review125801
-----------------------------------------------------------
Made a few quick comments. I didn't look at the `CheckOverlapTree` logic itself yet though.
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 33)
<https://reviews.apache.org/r/42860/#comment188676>
Semicolon seems unnecessary.
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 53)
<https://reviews.apache.org/r/42860/#comment188677>
Semicolon seems unnecessary.
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 126)
<https://reviews.apache.org/r/42860/#comment188679>
Can we clarify what "overlapping" means here?
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 127)
<https://reviews.apache.org/r/42860/#comment188680>
What does "flat" mean, here? Also, is it worth adding a `CHECK` that all paths are absolute?
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 128)
<https://reviews.apache.org/r/42860/#comment188678>
Should probably be `const std::vector<std::string>&`.
- Neil Conway
On March 29, 2016, 2:30 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42860/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 2:30 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-4521
> https://issues.apache.org/jira/browse/MESOS-4521
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add paths::overlapping to check whether paths are overlapping.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f
> 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697
>
> Diff: https://reviews.apache.org/r/42860/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42860: Add paths::overlapping to check whether
paths are overlapping.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/
-----------------------------------------------------------
(Updated April 1, 2016, 4:42 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, Joris Van Remoortere, and Neil Conway.
Changes
-------
Fix incorrect test case.
Bugs: MESOS-4521
https://issues.apache.org/jira/browse/MESOS-4521
Repository: mesos
Description
-------
Add paths::overlapping to check whether paths are overlapping.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697
Diff: https://reviews.apache.org/r/42860/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 42860: Add paths::overlapping to check whether
paths are overlapping.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/
-----------------------------------------------------------
(Updated March 29, 2016, 5:33 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, Joris Van Remoortere, and Neil Conway.
Changes
-------
Rebase.
Bugs: MESOS-4521
https://issues.apache.org/jira/browse/MESOS-4521
Repository: mesos
Description
-------
Add paths::overlapping to check whether paths are overlapping.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697
Diff: https://reviews.apache.org/r/42860/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 42860: Add paths::overlapping to check whether
paths are overlapping.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/
-----------------------------------------------------------
(Updated March 29, 2016, 5:29 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, Joris Van Remoortere, and Neil Conway.
Changes
-------
Rebase.
Bugs: MESOS-4521
https://issues.apache.org/jira/browse/MESOS-4521
Repository: mesos
Description
-------
Add paths::overlapping to check whether paths are overlapping.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697
Diff: https://reviews.apache.org/r/42860/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 42860: Add paths::overlapping to check whether
paths are overlapping.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/
-----------------------------------------------------------
(Updated March 29, 2016, 8:56 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, Joris Van Remoortere, and Neil Conway.
Changes
-------
Address @neilc comments.
Bugs: MESOS-4521
https://issues.apache.org/jira/browse/MESOS-4521
Repository: mesos
Description
-------
Add paths::overlapping to check whether paths are overlapping.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697
Diff: https://reviews.apache.org/r/42860/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 42860: Add paths::overlapping to check whether
paths are overlapping.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/
-----------------------------------------------------------
(Updated March 29, 2016, 2:30 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, Joris Van Remoortere, and Neil Conway.
Changes
-------
Address @comments.
Summary (updated)
-----------------
Add paths::overlapping to check whether paths are overlapping.
Bugs: MESOS-4521
https://issues.apache.org/jira/browse/MESOS-4521
Repository: mesos
Description (updated)
-------
Add paths::overlapping to check whether paths are overlapping.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697
Diff: https://reviews.apache.org/r/42860/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 42860: Add paths::sameParent to find out the same
root of a path list.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/
-----------------------------------------------------------
(Updated Jan. 28, 2016, 2:12 a.m.)
Review request for mesos, Jie Yu and Joris Van Remoortere.
Bugs: MESOS-4521
https://issues.apache.org/jira/browse/MESOS-4521
Repository: mesos
Description
-------
Add paths::sameParent to find out the same root of a path list.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697
Diff: https://reviews.apache.org/r/42860/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 42860: Add paths::sameParent to find out the same
root of a path list.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/
-----------------------------------------------------------
(Updated Jan. 27, 2016, 6:36 p.m.)
Review request for mesos, Jie Yu and Joris Van Remoortere.
Changes
-------
Rebase
Bugs: MESOS-4521
https://issues.apache.org/jira/browse/MESOS-4521
Repository: mesos
Description
-------
Add paths::sameParent to find out the same root of a path list.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697
Diff: https://reviews.apache.org/r/42860/diff/
Testing
-------
Thanks,
haosdent huang