You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/22 19:18:37 UTC
Re: Review Request 66649: Added pb2gen.sh for generating python
protobuf bindings.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66649/#review213093
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66649]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Dec. 6, 2018, 4:26 a.m., Eric Chung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66649/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2018, 4:26 a.m.)
>
>
> Review request for mesos, Armand Grillet, Jason Lai, Kevin Klues, and Zhitao Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The current state of support for python in protoc has two serious
> issues:
> 1. The `__init__.py` files necessary to mark a directory as a python
> package aren't generated.
> 2. The import paths in each of the generated .py files do not reflect
> the `--python_path` option passed to `protoc`.
>
> This results in incomplete code generated, preventing it from being used
> out of the box. To address this issue, we're adding a `pb2gen.sh` script
> to do end-to-end code generation for python protobuf bindings: the
> script generates the bindings based on what's in the `include` dir, then
> postprocesses the generated code to add proper import paths and the
> `__init__.py` files.
>
>
> Diffs
> -----
>
> src/python/.gitignore fee529dccf57fd24036733f4b470b7b9865a918c
> src/python/lib/pb2gen.sh PRE-CREATION
> src/python/lib/requirements.in 86ee2ad40c0c114b0082f2d4f52f75758d41cbd9
> support/pylint.config af25dd90cb2d467c688ea4b060dc4640040a068b
>
>
> Diff: https://reviews.apache.org/r/66649/diff/7/
>
>
> Testing
> -------
>
> 1. under `src/python/lib`, run `pb2gen.sh`
> 2. initialize and activate virtualenv: `virtualenv env && . env/bin/activate`
> 3. install reqs: `pip install -r requirements.in`
> 4. try to import modules from generated python code: `python -c 'from mesos.pb2.mesos.v1.master import master_pb2'`
>
>
> Thanks,
>
> Eric Chung
>
>