You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/10/05 21:28:52 UTC

[GitHub] [helix] mgao0 commented on pull request #1436: Not to reuse data accessor in Helix customized state provider

mgao0 commented on pull request #1436:
URL: https://github.com/apache/helix/pull/1436#issuecomment-703899196


   Code looks good to me. Could you please some more details in the PR description explaining why we want to make this change? Such as when Helix manager connects, it will create new client, etc.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org