You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/30 15:07:29 UTC
[GitHub] [airflow] ohadmata opened a new pull request #8016: AIRFLOW-7115
Update dag.html
ohadmata opened a new pull request #8016: AIRFLOW-7115 Update dag.html
URL: https://github.com/apache/airflow/pull/8016
display the dag owner in the dag view
The change fixes also my minor bug: AIRFLOW-7114
https://issues.apache.org/jira/browse/AIRFLOW-7115
https://issues.apache.org/jira/browse/AIRFLOW-7114
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #8016:
[AIRFLOW-7115] Display the dag owner in the dag view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view
URL: https://github.com/apache/airflow/pull/8016#issuecomment-606138067
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=h1) Report
> Merging [#8016](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=desc) into [v1-10-stable](https://codecov.io/gh/apache/airflow/commit/c8597cbf143b970ad3c7b0d62e3b44d1dfdc8afe&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v1-10-stable #8016 +/- ##
================================================
- Coverage 81.50% 81.25% -0.26%
================================================
Files 526 529 +3
Lines 36032 36436 +404
================================================
+ Hits 29368 29605 +237
- Misses 6664 6831 +167
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/cassandra\_hook.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2Nhc3NhbmRyYV9ob29rLnB5) | `16.88% <0.00%> (-76.63%)` | :arrow_down: |
| [...irflow/contrib/operators/redis\_publish\_operator.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9yZWRpc19wdWJsaXNoX29wZXJhdG9yLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/contrib/sensors/mongo\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbW9uZ29fc2Vuc29yLnB5) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `47.79% <0.00%> (-41.10%)` | :arrow_down: |
| [airflow/contrib/sensors/redis\_key\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcmVkaXNfa2V5X3NlbnNvci5weQ==) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/models/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvX19pbml0X18ucHk=) | `92.00% <0.00%> (-8.00%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `86.02% <0.00%> (-4.49%)` | :arrow_down: |
| [airflow/contrib/hooks/mongo\_hook.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL21vbmdvX2hvb2sucHk=) | `93.15% <0.00%> (-4.11%)` | :arrow_down: |
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.06% <0.00%> (-4.03%)` | :arrow_down: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.98% <0.00%> (-3.28%)` | :arrow_down: |
| ... and [76 more](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=footer). Last update [c8597cb...ba4dab6](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ohadmata removed a comment on issue #8016: AIRFLOW-7115
display the dag owner in the dag view
Posted by GitBox <gi...@apache.org>.
ohadmata removed a comment on issue #8016: AIRFLOW-7115 display the dag owner in the dag view
URL: https://github.com/apache/airflow/pull/8016#issuecomment-606060866
Hi, anyone knows why mergable don't like my description?
I added the Jira links. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] eladkal commented on issue #8016: [AIRFLOW-7115] Display
the dag owner in the dag view
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view
URL: https://github.com/apache/airflow/pull/8016#issuecomment-606468661
This PR is against 1.10 branch. Doesn't it also apply to master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #8016:
[AIRFLOW-7115] Display the dag owner in the dag view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view
URL: https://github.com/apache/airflow/pull/8016#issuecomment-606138067
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=h1) Report
> Merging [#8016](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=desc) into [v1-10-stable](https://codecov.io/gh/apache/airflow/commit/c8597cbf143b970ad3c7b0d62e3b44d1dfdc8afe&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v1-10-stable #8016 +/- ##
================================================
- Coverage 81.50% 81.25% -0.26%
================================================
Files 526 529 +3
Lines 36032 36436 +404
================================================
+ Hits 29368 29605 +237
- Misses 6664 6831 +167
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/cassandra\_hook.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2Nhc3NhbmRyYV9ob29rLnB5) | `16.88% <0.00%> (-76.63%)` | :arrow_down: |
| [...irflow/contrib/operators/redis\_publish\_operator.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9yZWRpc19wdWJsaXNoX29wZXJhdG9yLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/contrib/sensors/mongo\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbW9uZ29fc2Vuc29yLnB5) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `47.79% <0.00%> (-41.10%)` | :arrow_down: |
| [airflow/contrib/sensors/redis\_key\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcmVkaXNfa2V5X3NlbnNvci5weQ==) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/models/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvX19pbml0X18ucHk=) | `92.00% <0.00%> (-8.00%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `86.02% <0.00%> (-4.49%)` | :arrow_down: |
| [airflow/contrib/hooks/mongo\_hook.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL21vbmdvX2hvb2sucHk=) | `93.15% <0.00%> (-4.11%)` | :arrow_down: |
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.06% <0.00%> (-4.03%)` | :arrow_down: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.98% <0.00%> (-3.28%)` | :arrow_down: |
| ... and [76 more](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=footer). Last update [c8597cb...ba4dab6](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #8016:
[AIRFLOW-7115] Display the dag owner in the dag view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view
URL: https://github.com/apache/airflow/pull/8016#issuecomment-606138067
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=h1) Report
> Merging [#8016](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=desc) into [v1-10-stable](https://codecov.io/gh/apache/airflow/commit/c8597cbf143b970ad3c7b0d62e3b44d1dfdc8afe&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v1-10-stable #8016 +/- ##
================================================
- Coverage 81.50% 81.25% -0.26%
================================================
Files 526 529 +3
Lines 36032 36436 +404
================================================
+ Hits 29368 29605 +237
- Misses 6664 6831 +167
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/cassandra\_hook.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2Nhc3NhbmRyYV9ob29rLnB5) | `16.88% <0.00%> (-76.63%)` | :arrow_down: |
| [...irflow/contrib/operators/redis\_publish\_operator.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9yZWRpc19wdWJsaXNoX29wZXJhdG9yLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/contrib/sensors/mongo\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbW9uZ29fc2Vuc29yLnB5) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `47.79% <0.00%> (-41.10%)` | :arrow_down: |
| [airflow/contrib/sensors/redis\_key\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcmVkaXNfa2V5X3NlbnNvci5weQ==) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/models/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvX19pbml0X18ucHk=) | `92.00% <0.00%> (-8.00%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `86.02% <0.00%> (-4.49%)` | :arrow_down: |
| [airflow/contrib/hooks/mongo\_hook.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL21vbmdvX2hvb2sucHk=) | `93.15% <0.00%> (-4.11%)` | :arrow_down: |
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.06% <0.00%> (-4.03%)` | :arrow_down: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.98% <0.00%> (-3.28%)` | :arrow_down: |
| ... and [76 more](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=footer). Last update [c8597cb...ba4dab6](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil edited a comment on issue #8016: [AIRFLOW-7115]
Display the dag owner in the dag view
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view
URL: https://github.com/apache/airflow/pull/8016#issuecomment-609866268
Can you please create this PR against Master? This PR also just updated to Flask-admin based UI.
Also, I don't feel we should add "Owner" info too. It is on the HomePage, that is more than enough I think.
PS: I have not included this in 1.10.10
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #8016: [AIRFLOW-7115]
Display the dag owner in the dag view
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view
URL: https://github.com/apache/airflow/pull/8016#issuecomment-606138067
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=h1) Report
> Merging [#8016](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=desc) into [v1-10-stable](https://codecov.io/gh/apache/airflow/commit/c8597cbf143b970ad3c7b0d62e3b44d1dfdc8afe&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v1-10-stable #8016 +/- ##
================================================
- Coverage 81.50% 81.25% -0.26%
================================================
Files 526 529 +3
Lines 36032 36436 +404
================================================
+ Hits 29368 29605 +237
- Misses 6664 6831 +167
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/cassandra\_hook.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2Nhc3NhbmRyYV9ob29rLnB5) | `16.88% <0.00%> (-76.63%)` | :arrow_down: |
| [...irflow/contrib/operators/redis\_publish\_operator.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9yZWRpc19wdWJsaXNoX29wZXJhdG9yLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/contrib/sensors/mongo\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbW9uZ29fc2Vuc29yLnB5) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `47.79% <0.00%> (-41.10%)` | :arrow_down: |
| [airflow/contrib/sensors/redis\_key\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcmVkaXNfa2V5X3NlbnNvci5weQ==) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/models/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvX19pbml0X18ucHk=) | `92.00% <0.00%> (-8.00%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `86.02% <0.00%> (-4.49%)` | :arrow_down: |
| [airflow/contrib/hooks/mongo\_hook.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL21vbmdvX2hvb2sucHk=) | `93.15% <0.00%> (-4.11%)` | :arrow_down: |
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.06% <0.00%> (-4.03%)` | :arrow_down: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.98% <0.00%> (-3.28%)` | :arrow_down: |
| ... and [76 more](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=footer). Last update [c8597cb...ba4dab6](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #8016: [AIRFLOW-7115] Display
the dag owner in the dag view
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #8016: [AIRFLOW-7115] Display the dag owner in the dag view
URL: https://github.com/apache/airflow/pull/8016
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #8016:
[AIRFLOW-7115] Display the dag owner in the dag view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view
URL: https://github.com/apache/airflow/pull/8016#issuecomment-606138067
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=h1) Report
> Merging [#8016](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=desc) into [v1-10-stable](https://codecov.io/gh/apache/airflow/commit/c8597cbf143b970ad3c7b0d62e3b44d1dfdc8afe&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v1-10-stable #8016 +/- ##
================================================
- Coverage 81.50% 81.25% -0.26%
================================================
Files 526 529 +3
Lines 36032 36436 +404
================================================
+ Hits 29368 29605 +237
- Misses 6664 6831 +167
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/cassandra\_hook.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2Nhc3NhbmRyYV9ob29rLnB5) | `16.88% <0.00%> (-76.63%)` | :arrow_down: |
| [...irflow/contrib/operators/redis\_publish\_operator.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9yZWRpc19wdWJsaXNoX29wZXJhdG9yLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/contrib/sensors/mongo\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbW9uZ29fc2Vuc29yLnB5) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `47.79% <0.00%> (-41.10%)` | :arrow_down: |
| [airflow/contrib/sensors/redis\_key\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcmVkaXNfa2V5X3NlbnNvci5weQ==) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/models/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvX19pbml0X18ucHk=) | `92.00% <0.00%> (-8.00%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `86.02% <0.00%> (-4.49%)` | :arrow_down: |
| [airflow/contrib/hooks/mongo\_hook.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL21vbmdvX2hvb2sucHk=) | `93.15% <0.00%> (-4.11%)` | :arrow_down: |
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.06% <0.00%> (-4.03%)` | :arrow_down: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.98% <0.00%> (-3.28%)` | :arrow_down: |
| ... and [76 more](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=footer). Last update [c8597cb...ba4dab6](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #8016: [AIRFLOW-7115] Display
the dag owner in the dag view
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view
URL: https://github.com/apache/airflow/pull/8016#issuecomment-609866268
Can you please create this PR against Master? This PR also just updated to Flask-admin based UI.
Also, I don't feel we should add "Owner" info too. It is on the HomePage, that is more than enough I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #8016:
[AIRFLOW-7115] Display the dag owner in the dag view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view
URL: https://github.com/apache/airflow/pull/8016#issuecomment-606138067
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=h1) Report
> Merging [#8016](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=desc) into [v1-10-stable](https://codecov.io/gh/apache/airflow/commit/c8597cbf143b970ad3c7b0d62e3b44d1dfdc8afe&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v1-10-stable #8016 +/- ##
================================================
- Coverage 81.50% 81.25% -0.26%
================================================
Files 526 529 +3
Lines 36032 36436 +404
================================================
+ Hits 29368 29605 +237
- Misses 6664 6831 +167
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/cassandra\_hook.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2Nhc3NhbmRyYV9ob29rLnB5) | `16.88% <0.00%> (-76.63%)` | :arrow_down: |
| [...irflow/contrib/operators/redis\_publish\_operator.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9yZWRpc19wdWJsaXNoX29wZXJhdG9yLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/contrib/sensors/mongo\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbW9uZ29fc2Vuc29yLnB5) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `47.79% <0.00%> (-41.10%)` | :arrow_down: |
| [airflow/contrib/sensors/redis\_key\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcmVkaXNfa2V5X3NlbnNvci5weQ==) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/models/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvX19pbml0X18ucHk=) | `92.00% <0.00%> (-8.00%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `86.02% <0.00%> (-4.49%)` | :arrow_down: |
| [airflow/contrib/hooks/mongo\_hook.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL21vbmdvX2hvb2sucHk=) | `93.15% <0.00%> (-4.11%)` | :arrow_down: |
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.06% <0.00%> (-4.03%)` | :arrow_down: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.98% <0.00%> (-3.28%)` | :arrow_down: |
| ... and [76 more](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=footer). Last update [c8597cb...ba4dab6](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #8016: [AIRFLOW-7115]
Display the dag owner in the dag view
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view
URL: https://github.com/apache/airflow/pull/8016#issuecomment-609887862
FYI, I think we should add KEYWORD text `description` before `{{ dag.description }}`, otherwise will be `Owner: <owner> <description>` if `dag.description` is not null, which may confuse user the whole `<owner> <description>` are owner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #8016: [AIRFLOW-7115] Display
the dag owner in the dag view
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view
URL: https://github.com/apache/airflow/pull/8016#issuecomment-606485975
Ah. Good point @eladkal -> thanks for noticing !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ohadmata commented on issue #8016: AIRFLOW-7115 display
the dag owner in the dag view
Posted by GitBox <gi...@apache.org>.
ohadmata commented on issue #8016: AIRFLOW-7115 display the dag owner in the dag view
URL: https://github.com/apache/airflow/pull/8016#issuecomment-606060866
Hi, anyone knows why mergable don't like my description?
I added the Jira links. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #8016: [AIRFLOW-7115]
Display the dag owner in the dag view
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view
URL: https://github.com/apache/airflow/pull/8016#issuecomment-609888638
And I agree with kaxil point about that.
> Also, I don't feel we should add "Owner" info too. It is on the HomePage, that is more than enough I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #8016:
[AIRFLOW-7115] Display the dag owner in the dag view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view
URL: https://github.com/apache/airflow/pull/8016#issuecomment-606138067
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=h1) Report
> Merging [#8016](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=desc) into [v1-10-stable](https://codecov.io/gh/apache/airflow/commit/c8597cbf143b970ad3c7b0d62e3b44d1dfdc8afe&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v1-10-stable #8016 +/- ##
================================================
- Coverage 81.50% 81.25% -0.26%
================================================
Files 526 529 +3
Lines 36032 36436 +404
================================================
+ Hits 29368 29605 +237
- Misses 6664 6831 +167
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/cassandra\_hook.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2Nhc3NhbmRyYV9ob29rLnB5) | `16.88% <0.00%> (-76.63%)` | :arrow_down: |
| [...irflow/contrib/operators/redis\_publish\_operator.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9yZWRpc19wdWJsaXNoX29wZXJhdG9yLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/contrib/sensors/mongo\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbW9uZ29fc2Vuc29yLnB5) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `47.79% <0.00%> (-41.10%)` | :arrow_down: |
| [airflow/contrib/sensors/redis\_key\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcmVkaXNfa2V5X3NlbnNvci5weQ==) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/models/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvX19pbml0X18ucHk=) | `92.00% <0.00%> (-8.00%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `86.02% <0.00%> (-4.49%)` | :arrow_down: |
| [airflow/contrib/hooks/mongo\_hook.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL21vbmdvX2hvb2sucHk=) | `93.15% <0.00%> (-4.11%)` | :arrow_down: |
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.06% <0.00%> (-4.03%)` | :arrow_down: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.98% <0.00%> (-3.28%)` | :arrow_down: |
| ... and [76 more](https://codecov.io/gh/apache/airflow/pull/8016/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=footer). Last update [c8597cb...ba4dab6](https://codecov.io/gh/apache/airflow/pull/8016?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services