You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2016/10/10 17:04:35 UTC

[GitHub] tinkerpop pull request #453: TINKERPOP-1492: RemoteStrategy or the RemoteCon...

GitHub user okram opened a pull request:

    https://github.com/apache/tinkerpop/pull/453

    TINKERPOP-1492: RemoteStrategy or the RemoteConnection should append a lazy barrier().

    https://issues.apache.org/jira/browse/TINKERPOP-1492
    
    I think that `LazyBarrierStrategy` should add a `barrier()` to the end of a traversal if it believes it will reduce the number of traversers. This is particularly important for `withRemote()` as you can greatly reduce the network traffic. I don't have a good way of knowing if the traversal is being executed remote or not so this will lazy `barrier()` will be added regardless of remote'ing. 
    
    Please review and tell me if you disagree with where I am placing this optimization.
    
    VOTE +1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1492

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/453.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #453
    
----
commit 7c026acb905b68bddf46f0f6bb8501471e347d67
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2016-10-10T16:50:54Z

    if the probability of bulking is high at the end step, a barrier(SIZE) is inserted.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #453: TINKERPOP-1492: RemoteStrategy or the RemoteConnection...

Posted by dkuppitz <gi...@git.apache.org>.

Github user dkuppitz commented on the issue:

    https://github.com/apache/tinkerpop/pull/453
  
    Code changes + tests look good.
    
    VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #453: TINKERPOP-1492: RemoteStrategy or the RemoteConnection...

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/453
  
    All tests pass with `docker/build.sh -t -i`
    
    VOTE +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #453: TINKERPOP-1492: RemoteStrategy or the RemoteCon...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/453


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---