You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/28 13:34:55 UTC
[GitHub] [shardingsphere] laingke opened a new pull request #8399: test: Testcase for ParseTreeCacheBuilder
laingke opened a new pull request #8399:
URL: https://github.com/apache/shardingsphere/pull/8399
Fixes #8238 .
Changes proposed in this pull request:
- Add testcase for ParseTreeCacheBuilder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #8399: test: Testcase for ParseTreeCacheBuilder
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #8399:
URL: https://github.com/apache/shardingsphere/pull/8399#issuecomment-745115814
No response
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #8399: test: Testcase for ParseTreeCacheBuilder
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #8399:
URL: https://github.com/apache/shardingsphere/pull/8399#discussion_r532044809
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/test/java/org/apache/shardingsphere/sql/parser/core/cache/ParseTreeCacheBuilderTest.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.core.cache;
+
+import com.google.common.cache.LoadingCache;
+import org.apache.shardingsphere.sql.parser.api.CacheOption;
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.hamcrest.core.Is.isA;
+import static org.junit.Assert.assertThat;
+
+/**
+ * ParseTreeCacheBuilder Testcase.
+ */
Review comment:
Please remove useless comment, only java doc in prod codes are necessary.
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/test/java/org/apache/shardingsphere/sql/parser/core/cache/ParseTreeCacheBuilderTest.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.core.cache;
+
+import com.google.common.cache.LoadingCache;
+import org.apache.shardingsphere.sql.parser.api.CacheOption;
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.hamcrest.core.Is.isA;
+import static org.junit.Assert.assertThat;
+
+/**
+ * ParseTreeCacheBuilder Testcase.
+ */
+public class ParseTreeCacheBuilderTest {
+
+ private CacheOption option;
+
+ private String databaseType;
+
+ /**
+ * define cacheOption & databaseType.
+ */
Review comment:
Please remove useless comment, only java doc in prod codes are necessary.
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/test/java/org/apache/shardingsphere/sql/parser/core/cache/ParseTreeCacheBuilderTest.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.core.cache;
+
+import com.google.common.cache.LoadingCache;
+import org.apache.shardingsphere.sql.parser.api.CacheOption;
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.hamcrest.core.Is.isA;
+import static org.junit.Assert.assertThat;
+
+/**
+ * ParseTreeCacheBuilder Testcase.
+ */
+public class ParseTreeCacheBuilderTest {
Review comment:
Please add final if the class is not design for extension
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed pull request #8399: test: Testcase for ParseTreeCacheBuilder
Posted by GitBox <gi...@apache.org>.
terrymanu closed pull request #8399:
URL: https://github.com/apache/shardingsphere/pull/8399
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org