[GitHub] [kafka] mjsax commented on a change in pull request #10205: KAFKA-12323 Follow-up: Refactor the unit test a bit

[GitBox <gi...@apache.org>]

mjsax commented on a change in pull request #10205:
URL: https://github.com/apache/kafka/pull/10205#discussion_r582349190



##########
File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java
##########
@@ -1844,19 +1844,17 @@ public void process(final Object key, final Object value) {}
         assertEquals(0, punctuatedWallClockTime.size());
 
         mockTime.sleep(100L);
-        for (long i = 0L; i < 10L; i++) {

Review comment:
       Why do we remove this loop?

##########
File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java
##########
@@ -1936,7 +1934,7 @@ public void process(final Object key, final Object value) {
         clientSupplier.consumer.addRecord(new ConsumerRecord<>(
             topic1,
             1,
-            0L,
+            100L,

Review comment:
       nit: can we pick a different value to disambiguate (wall-clock time is set to `100L` above)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org