[GitHub] [helix] narendly commented on a change in pull request #690: Reset the WAGED rebalancer once the controller newly acquires leadership.

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #690: Reset the WAGED rebalancer once the controller newly acquires leadership.
URL: https://github.com/apache/helix/pull/690#discussion_r369856439
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
 ##########
 @@ -626,6 +631,22 @@ private void handleEvent(ClusterEvent event, BaseControllerDataProvider dataProv
       return;
     }
 
+    // Event handling happens in a different thread from the onControllerChange processing thread.
+    // Thus, there are several possible conditions.
+    // 1. Event handled after leadership acquired. So we will have a valid rebalancer for the
+    // event processing.
+    // 2. Event handled shortly after leadership relinquished. And the rebalancer has not been
 
 Review comment:
   Do you mean that the old controller will continue to process events even after having lost the leadership using the in-memory rebalancer/cache state?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org