You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/17 01:14:29 UTC
[GitHub] [airflow] josh-fell commented on a change in pull request #20234: Fix mypy errors for google.cloud_build
josh-fell commented on a change in pull request #20234:
URL: https://github.com/apache/airflow/pull/20234#discussion_r771030483
##########
File path: airflow/providers/google/cloud/hooks/cloud_build.py
##########
@@ -123,9 +123,13 @@ def cancel_build(
self.log.info("Start cancelling build: %s.", id_)
- build = client.cancel_build(
- request={'project_id': project_id, 'id': id_}, retry=retry, timeout=timeout, metadata=metadata
+ cancel_build = client.cancel_build(
+ request={'project_id': project_id, 'id': id_},
+ retry=retry,
+ timeout=timeout,
+ metadata=metadata,
)
+ build = cancel_build
Review comment:
What was MyPy complaining about here to update the variable name from `build` to `cancel_build`? Would it make sense to return cancel_build` rather than set `build = cancel_build`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org