[GitHub] [netbeans] eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…

[GitBox <gi...@apache.org>]

eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…
URL: https://github.com/apache/netbeans/pull/1839#discussion_r362819104
 
 

 ##########
 File path: platform/openide.awt/src/org/openide/awt/CloseButtonFactory.java
 ##########
 @@ -141,6 +141,9 @@ private static boolean isGTKLaF () {
     }
 
     private static Icon getCloseTabImage() {
+        if( null == closeTabImage ) {
+            closeTabImage = UIManager.getIcon("nb.close.tab.icon.enabled.icon"); //NOI18N
 
 Review comment:
   Adding new keys to UIManager.getDefaults() constitutes an API change; should probably update apichanges.xml. And perhaps go over the names of the new keys one more time to make sure they follow the convention of the existing keys.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists