[jira] Created: (MYFACES-2493) ViewMetadata facelets compiler should not output DTD,

ViewMetadata facelets compiler should not output DTD, <?xml or any UIInstruction outside f:metadata
---------------------------------------------------------------------------------------------------

                 Key: MYFACES-2493
                 URL: https://issues.apache.org/jira/browse/MYFACES-2493
             Project: MyFaces Core
          Issue Type: Task
          Components: JSR-314
    Affects Versions: 2.0.0-alpha
            Reporter: Leonardo Uribe
            Assignee: Leonardo Uribe


This does not have any side effects but originally, FaceletViewHandler used this line on renderView method:

            // build view - but not if we're in "buildBeforeRestore"
            // land and we've already got a populated view. Note
            // that this optimizations breaks if there's a "c:if" in
            // the page that toggles as a result of request processing -
            // should that be handled? Or
            // is this optimization simply so minor that it should just
            // be trimmed altogether?
            if (!this.buildBeforeRestore || viewToRender.getChildren().isEmpty())
            {
                this.buildView(context, viewToRender);
            }

Since we need to solve MYFACES-2483 Find a way to allow c:if work with partial state saving enabled, we need a way to detect when a view is "updated", and check if UIViewRoot has children is ideal. 



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

---

[jira] Resolved: (MYFACES-2493) ViewMetadata facelets compiler should not output DTD, Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.

---

     [ https://issues.apache.org/jira/browse/MYFACES-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved MYFACES-2493.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0-alpha-2

> ViewMetadata facelets compiler should not output DTD, <?xml or any UIInstruction outside f:metadata
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2493
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2493
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>             Fix For: 2.0.0-alpha-2
>
>
> This does not have any side effects but originally, FaceletViewHandler used this line on renderView method:
>             // build view - but not if we're in "buildBeforeRestore"
>             // land and we've already got a populated view. Note
>             // that this optimizations breaks if there's a "c:if" in
>             // the page that toggles as a result of request processing -
>             // should that be handled? Or
>             // is this optimization simply so minor that it should just
>             // be trimmed altogether?
>             if (!this.buildBeforeRestore || viewToRender.getChildren().isEmpty())
>             {
>                 this.buildView(context, viewToRender);
>             }
> Since we need to solve MYFACES-2483 Find a way to allow c:if work with partial state saving enabled, we need a way to detect when a view is "updated", and check if UIViewRoot has children is ideal. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

---