[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #28: Cdi parameter resolver

[GitBox <gi...@apache.org>]

rmannibucau commented on a change in pull request #28:
URL: https://github.com/apache/openwebbeans/pull/28#discussion_r439796088



##########
File path: webbeans-junit5/src/main/java/org/apache/openwebbeans/junit5/Cdi.java
##########
@@ -80,6 +80,11 @@
      */
     boolean disableDiscovery() default false;
 
+    /**
+     * @return {@code true} to enable JUnit parameter resolution with CDI beans or {@code false} otherwise.
+     */
+    boolean injectParameters() default true;

Review comment:
       Hi @philippkunz , I was more thinking about another annotation cause it can't be global.
   Here is an example:
   
       @Test void test( MyCdiBeanInjectedByJUnitExtension1 b2, MyCdibeanInjectedByCdiExtension b2 ) {}
   
   If cdi extension runs first it does not work so we must have:
   
       @Test void test( @Cdi.SkipInject MyCdiBeanInjectedByJUnitExtension1 b2, MyCdibeanInjectedByCdiExtension b2 ) {}
   
   (or equivalent API). Note that making SkipInject a qualifier (added from an implicit extension in the extension) makes it trivial to impl ;).
   
   Hope it makes sense




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org