You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by jcounts <gi...@git.apache.org> on 2015/08/20 20:44:13 UTC
[GitHub] couchdb-chttpd pull request: handle_system_req Memory includes tot...
GitHub user jcounts opened a pull request:
https://github.com/apache/couchdb-chttpd/pull/59
handle_system_req Memory includes total
@rnewson
Originally was done here: https://github.com/cloudant/chttpd
moved to this repo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-chttpd 47888-add-totol-memory-to-handle_system_req
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-chttpd/pull/59.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #59
----
commit 19d9bddcfdb630af7ec79b9fb9d3ee0f19540160
Author: Jordan Counts <jc...@gmail.com>
Date: 2015-08-20T18:40:58Z
handle_system_req Memory includes total
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: handle_system_req Memory includes tot...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/59#issuecomment-133678052
Hm, not sure what's use case for this patch. Example output:
```
"memory": {
"atom": 801697,
"atom_used": 793412,
"binary": 1656328,
"code": 23299745,
"ets": 1753608,
"other": -36439634,
"processes": 8933048,
"processes_used": 8919640
}
```
Notice negative other value. I believe, total value should be shows with separate object field.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: handle_system_req Memory includes tot...
Posted by jcounts <gi...@git.apache.org>.
Github user jcounts commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/59#issuecomment-134400909
hmm...I wasn't sure if this would solve my problem or not. This was a response for:
https://cloudant.fogbugz.com/f/cases/47888/DBcore-memory-usage-displayed-in-admin-dashboard-is-wrong
Which is a bug in:
https://github.com/cloudant/wilson/blob/develop/wilson/views/clusters.py
The Wilson endpoint pulls info from graphite (and haproxy).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: handle_system_req Memory includes tot...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/59#issuecomment-133124878
How can I trigger this handler via HTTP API? So far I see there is no place in code that makes it available to handle incoming requests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: handle_system_req Memory includes tot...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/59#issuecomment-133150984
@kxepal: does seem to be missing from https://github.com/apache/couchdb-chttpd/blob/master/src/chttpd_httpd_handlers.erl :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: handle_system_req Memory includes tot...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/59#issuecomment-133327050
@rnewson Yes, I noticed that, but commentary for the handler says that it's only available for backdoor interface...or at least it should be.
I'll add it to default.ini where global httpd handlers are defined and ensure what it's available by `/_node/X/_system` path on cluster interface, ok?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: handle_system_req Memory includes tot...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/59#issuecomment-133349790
actually /_system is available on both front and back ports at Cloudant, I just checked, so we should do the same.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: handle_system_req Memory includes tot...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/59#issuecomment-134402077
@jcounts Sorry, I don't have access to Cloudant fogbugz and private repositories. What's the case there is short which is fine to gather negative memory values?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: handle_system_req Memory includes tot...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/59#issuecomment-133350653
@rnewson ok, I'll made PRs for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: handle_system_req Memory includes tot...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/59#issuecomment-134402434
@jcounts also, how about to backport those fogbugz ticket to CouchDB JIRA and bound it with this commit? Would be helpful to track the things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request #59: handle_system_req Memory includes total
Posted by jcounts <gi...@git.apache.org>.
Github user jcounts closed the pull request at:
https://github.com/apache/couchdb-chttpd/pull/59
---
[GitHub] couchdb-chttpd pull request: handle_system_req Memory includes tot...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/59#issuecomment-133349449
ah, quite right. Let's just add it to :5986 for now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---