You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/27 03:46:24 UTC

[GitHub] [skywalking-java] wu-sheng commented on pull request #39: Add an agent plugin to support Jackson

wu-sheng commented on pull request #39:
URL: https://github.com/apache/skywalking-java/pull/39#issuecomment-927503766


   > Apart from the comments inline, I'd also like to discuss whether we should also include part of the JSON string / bytes in the trace, for example, collect the first 64 bytes as a tag `content` and the `64` is configurable.
   > 
   > Currently we only have the time cost in (de)serializing and the length of the content, but it makes little sense that we don't know what the content is when the time cost is too long, including part of the content might give the users some hints what content makes the JSON lib slower.
   
   Agree, collecting content is a risk. I prefer we don't do this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org