[GitHub] [incubator-shenyu] tuohai666 commented on a change in pull request #2779: 【RESLESE 2.4.2】LICENSE

[GitBox <gi...@apache.org>]

tuohai666 commented on a change in pull request #2779:
URL: https://github.com/apache/incubator-shenyu/pull/2779#discussion_r785450554



##########
File path: shenyu-dist/shenyu-bootstrap-dist/src/main/release-docs/LICENSE
##########
@@ -361,6 +361,21 @@ The text of each license is the standard Apache 2.0 license.
     zkclient 0.10: https://github.com/sgroschupf/zkclient, Apache 2.0
     zookeeper 3.5.6: https://github.com/apache/zookeeper, Apache 2.0
     zookeeper-jute 3.5.6: https://github.com/apache/zookeeper, Apache 2.0
+    byte-buddy 1.12.6: https://github.com/raphw/byte-buddy, Apache 2.0
+    byte-buddy-agent 1.12.6: https://github.com/raphw/byte-buddy, Apache 2.0
+    jaeger-client 1.6.0 https://github.com/jaegertracing/jaeger Apache 2.0
+    opentracing-api 0.33.0 https://github.com/opentracing/opentracing-java Apache 2.0

Review comment:
       opentraccing licenses already exist.

##########
File path: shenyu-dist/shenyu-bootstrap-dist/src/main/release-docs/NOTICE
##########
@@ -305,6 +305,26 @@ This product includes software developed at CoreOS, Inc.
 
 ========================================================================
 
+byte-buddy NOTICE

Review comment:
       Please also add zipkin NOTICE.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org