You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/24 10:58:33 UTC

[GitHub] [camel-website] shreyaag770 opened a new pull request #264: Projects

shreyaag770 opened a new pull request #264: Projects
URL: https://github.com/apache/camel-website/pull/264
 
 
   changes asked in PR  #237 is done in this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] shreyaag770 commented on issue #264: Changed alignment under Project section on frontpage

Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #264: Changed alignment under Project section on frontpage
URL: https://github.com/apache/camel-website/pull/264#issuecomment-606698783
 
 
   @zregvart Please, have a look at PR #296. I suppose the right alignment of headings looks better.
   
   Preview:
   
   ![z1](https://user-images.githubusercontent.com/43489853/78044401-4350a700-7392-11ea-9e6a-e1cdd6e76e50.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] shreyaag770 closed pull request #264: Changed alignment under Project section on frontpage

Posted by GitBox <gi...@apache.org>.
shreyaag770 closed pull request #264: Changed alignment under Project section on frontpage
URL: https://github.com/apache/camel-website/pull/264
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #264: Changed alignment under Project section on frontpage

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #264: Changed alignment under Project section on frontpage
URL: https://github.com/apache/camel-website/pull/264#discussion_r398447828
 
 

 ##########
 File path: antora-ui-camel/src/css/frontpage.css
 ##########
 @@ -260,4 +261,7 @@ section.frontpage h1 {
   section.frontpage.projects .project p:nth-child(3) {
     text-align: center;
   }
-}
+  section.frontpage.projects .project h1 {
+    text-align: center;
+  }
+}
 
 Review comment:
   This change fails the lint check.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #264: Changed alignment under Project section on frontpage

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #264: Changed alignment under Project section on frontpage
URL: https://github.com/apache/camel-website/pull/264#issuecomment-607129219
 
 
   @shreyaag770 its difficult to follow up on your pull requests can you close the ones that don't need to be merged and leave only the ones that you wish to have merged?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #264: Changed alignment under Project section on frontpage

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #264: Changed alignment under Project section on frontpage
URL: https://github.com/apache/camel-website/pull/264#issuecomment-606115672
 
 
   I've rebased and fixed the conflict. We don't have the preview so here's the current and the proposed screenshots.
   
   Current
   
   ![Screenshot_2020-03-30 Home - Apache Camel(1)](https://user-images.githubusercontent.com/1306050/77939351-52aef200-72b7-11ea-8b6f-d7f0d21e4ae2.png)
   
   Proposed
   
   ![Screenshot_2020-03-30 Home - Apache Camel](https://user-images.githubusercontent.com/1306050/77939363-580c3c80-72b7-11ea-9123-6e5ce91356f0.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] shreyaag770 commented on issue #264: Changed alignment under Project section on frontpage

Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #264: Changed alignment under Project section on frontpage
URL: https://github.com/apache/camel-website/pull/264#issuecomment-607142106
 
 
   ok @zregvart and I am really sorry, I am making your work hectic. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] shreyaag770 removed a comment on issue #264: Changed alignment under Project section on frontpage

Posted by GitBox <gi...@apache.org>.
shreyaag770 removed a comment on issue #264: Changed alignment under Project section on frontpage
URL: https://github.com/apache/camel-website/pull/264#issuecomment-606583825
 
 
   Thanks! @zregvart I have some suggestion for better alignment, what about the right alignment of headings under the project section.
   
   preview:
   ![z1](https://user-images.githubusercontent.com/43489853/78024089-6751bf80-7375-11ea-923d-4690b2f021c6.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] shreyaag770 commented on issue #264: Changed alignment under Project section on frontpage

Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #264: Changed alignment under Project section on frontpage
URL: https://github.com/apache/camel-website/pull/264#issuecomment-606583825
 
 
   Thanks! @zregvart I have some suggestion for better alignment, what about the right alignment of headings under the project section.
   
   preview:
   ![z1](https://user-images.githubusercontent.com/43489853/78024089-6751bf80-7375-11ea-923d-4690b2f021c6.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] shreyaag770 commented on issue #264: Changed alignment under Project section on frontpage

Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #264: Changed alignment under Project section on frontpage
URL: https://github.com/apache/camel-website/pull/264#issuecomment-604376266
 
 
   Done ! @zregvart, please review it again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services