[GitHub] [hudi] nsivabalan commented on a change in pull request #4572: [HUDI-2943] Complete pending clustering before deltastreamer sync

[GitBox <gi...@apache.org>]

nsivabalan commented on a change in pull request #4572:
URL: https://github.com/apache/hudi/pull/4572#discussion_r783141256



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -369,6 +369,9 @@ private boolean onDeltaSyncShutdown(boolean error) {
     @Parameter(names = {"--help", "-h"}, help = true)
     public Boolean help = false;
 
+    @Parameter(names = {"--retry-last-pending-clustering", "-rc"}, description = "Retry last pending clustering plan before writing to sink.")

Review comment:
       Can we fix description that this applies only for inline clustering.

##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -369,6 +369,9 @@ private boolean onDeltaSyncShutdown(boolean error) {
     @Parameter(names = {"--help", "-h"}, help = true)
     public Boolean help = false;
 
+    @Parameter(names = {"--retry-last-pending-clustering", "-rc"}, description = "Retry last pending clustering plan before writing to sink.")

Review comment:
       may be, we can even name the variable coveying the info
   --retry-last-pending-inline-clustering




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org