You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by ad...@apache.org on 2017/03/10 23:50:24 UTC
kudu git commit: thirdparty: disable REGISTER_INSTALL_PREFIX in
gflags build
Repository: kudu
Updated Branches:
refs/heads/master c5ec0ddb0 -> 80f951236
thirdparty: disable REGISTER_INSTALL_PREFIX in gflags build
It is enabled by default, and causes the built gflags package to be
"registered" in ~/.cmake/packages (CMake's package registry).
We don't use this feature, and we'd rather not leak build output out of the
Kudu build tree, so let's disable it.
Change-Id: I887da1ff31cb70901c649a83073a6a7ffcc06a3a
Reviewed-on: http://gerrit.cloudera.org:8080/6350
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/80f95123
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/80f95123
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/80f95123
Branch: refs/heads/master
Commit: 80f951236323797c9166b285c693f0ce3d3898d9
Parents: c5ec0dd
Author: Adar Dembo <ad...@cloudera.com>
Authored: Fri Mar 10 14:33:24 2017 -0800
Committer: Adar Dembo <ad...@cloudera.com>
Committed: Fri Mar 10 23:49:25 2017 +0000
----------------------------------------------------------------------
thirdparty/build-definitions.sh | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/80f95123/thirdparty/build-definitions.sh
----------------------------------------------------------------------
diff --git a/thirdparty/build-definitions.sh b/thirdparty/build-definitions.sh
index b45df3a..4626154 100644
--- a/thirdparty/build-definitions.sh
+++ b/thirdparty/build-definitions.sh
@@ -243,6 +243,7 @@ build_gflags() {
-DCMAKE_INSTALL_PREFIX=$PREFIX \
-DBUILD_SHARED_LIBS=On \
-DBUILD_STATIC_LIBS=On \
+ -DREGISTER_INSTALL_PREFIX=Off \
$GFLAGS_SOURCE
make -j$PARALLEL $EXTRA_MAKEFLAGS install
popd