[jira] [Commented] (IMPALA-5216) Admission control queuing should be asynchronous

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511338#comment-16511338 ] 

ASF subversion and git services commented on IMPALA-5216:
---------------------------------------------------------

Commit 2de9db8fc64dc1054ac3ca41ab0f0047db670da6 in impala's branch refs/heads/master from [~bikram.sngh91]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=2de9db8 ]

IMPALA-5216: Make admission control queuing async

Implement asynchronous admission control queuing. This is achieved by
running the admission control code-path in a separate thread. Major
changes include: propagating cancellation to the admission control
thread and dequeuing thread, and adding a new Query Operation State
called "PENDING" that represents the state between completion of
planning and starting of query execution.

Testing:
- Added a deterministic end to end test and a session expiry test.
- Ran multiple stress tests successfully with a cancellation probability
of 60% and with different values for the following parameters:
max_requests, queue_wait_timeout_ms. Ensured that the impalad was in a
valid state afterwards (no orphan fragments or wrong metrics).
- Ran all exhaustive tests and ASAN core tests successfully.
- Ran data load successfully.

Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf
Reviewed-on: http://gerrit.cloudera.org:8080/10060
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Admission control queuing should be asynchronous
> ------------------------------------------------
>
>                 Key: IMPALA-5216
>                 URL: https://issues.apache.org/jira/browse/IMPALA-5216
>             Project: IMPALA
>          Issue Type: Sub-task
>          Components: Backend
>            Reporter: Dan Hecht
>            Assignee: Bikramjeet Vig
>            Priority: Major
>              Labels: admission-control, resource-management
>
> Currently, admission control queuing occurs synchronously w.r.t. the {{ExecuteStatement}} client RPC. That is, a query handle is not returned until the query is admitted.
> Instead, the queuing should occur on the asynchronous path.  That way, the client gets a query handle back immediately and can e.g. cancel a query that is in the admission control queue.
> We'll also need a way to better expose the progress of a query handle (related to IMPALA-124). E.g. that the query is queued for admission and what resource(s) it's waiting on.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org