[jira] Updated: (DERBY-4918) Minor refactoring of SPSDescriptor

["Kristian Waagan (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-4918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4918:
-----------------------------------

    Attachment: derby-4918-1a-misc.stat

Attaching patch 1a.

Regression tests passed. Ready for review.

> Minor refactoring of SPSDescriptor
> ----------------------------------
>
>                 Key: DERBY-4918
>                 URL: https://issues.apache.org/jira/browse/DERBY-4918
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.8.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-4918-1a-misc.diff, derby-4918-1a-misc.stat
>
>
> The class SPSDescriptor is kind of hard to understand, and doesn't quite follow the pattern used by other tuple descriptors. Parts of the code don't agree with the documentation (i.e. SPS_TYPE_TRIGGER marked as not implemented)
> This issue tracks work to make the class easier to understand and to modify.
> The critical part that may need to be changed is the use of synchronized (this). The problem is that database locks are obtained within the critical regions, and in some special cases this causes deadlocks. I'm not yet certain this can be fixed at this level (only), but I'll continue investigation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.