You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Jeff Huff (JIRA)" <se...@james.apache.org> on 2010/06/18 23:47:23 UTC
[jira] Created: (JAMES-1019) getDomainsInternal in
JDBCVirtualUserTable needs reworked
getDomainsInternal in JDBCVirtualUserTable needs reworked
---------------------------------------------------------
Key: JAMES-1019
URL: https://issues.apache.org/jira/browse/JAMES-1019
Project: JAMES Server
Issue Type: Bug
Components: UsersStore & UsersRepository
Affects Versions: Trunk
Reporter: Jeff Huff
FindBugs reports the following error in JDBCVirtualUserTable.java
C:/svnpublic/james-server/user-function/src/main/java/org/apache/james/vut/JDBCVirtualUserTable.java:504 Call to equals() comparing different types
Should probably be more like this...
String domain = mappingRS.getString(1).toLowerCase();
if(domain.equals(WILDCARD) == false && domains.contains(domain) == false) {
domains.add(domain);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Closed: (JAMES-1019) getDomainsInternal in
JDBCVirtualUserTable needs reworked
Posted by "Eric Charles (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Charles closed JAMES-1019.
-------------------------------
Close it because fixed (btw virtualusertable does not implement domainlist anymore, see https://issues.apache.org/jira/browse/JAMES-1035)
> getDomainsInternal in JDBCVirtualUserTable needs reworked
> ---------------------------------------------------------
>
> Key: JAMES-1019
> URL: https://issues.apache.org/jira/browse/JAMES-1019
> Project: JAMES Server
> Issue Type: Bug
> Components: UsersStore & UsersRepository
> Affects Versions: Trunk
> Reporter: Jeff Huff
> Assignee: Norman Maurer
> Fix For: 3.0-M1
>
>
> FindBugs reports the following error in JDBCVirtualUserTable.java
> C:/svnpublic/james-server/user-function/src/main/java/org/apache/james/vut/JDBCVirtualUserTable.java:504 Call to equals() comparing different types
> Should probably be more like this...
> String domain = mappingRS.getString(1).toLowerCase();
> if(domain.equals(WILDCARD) == false && domains.contains(domain) == false) {
> domains.add(domain);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Resolved: (JAMES-1019) getDomainsInternal in
JDBCVirtualUserTable needs reworked
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Norman Maurer resolved JAMES-1019.
----------------------------------
Assignee: Norman Maurer
Fix Version/s: 3.0-M1
Resolution: Fixed
Fixed.... Thanks for reporting!
> getDomainsInternal in JDBCVirtualUserTable needs reworked
> ---------------------------------------------------------
>
> Key: JAMES-1019
> URL: https://issues.apache.org/jira/browse/JAMES-1019
> Project: JAMES Server
> Issue Type: Bug
> Components: UsersStore & UsersRepository
> Affects Versions: Trunk
> Reporter: Jeff Huff
> Assignee: Norman Maurer
> Fix For: 3.0-M1
>
>
> FindBugs reports the following error in JDBCVirtualUserTable.java
> C:/svnpublic/james-server/user-function/src/main/java/org/apache/james/vut/JDBCVirtualUserTable.java:504 Call to equals() comparing different types
> Should probably be more like this...
> String domain = mappingRS.getString(1).toLowerCase();
> if(domain.equals(WILDCARD) == false && domains.contains(domain) == false) {
> domains.add(domain);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org