You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "keon94 (via GitHub)" <gi...@apache.org> on 2023/08/16 14:55:16 UTC

[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #5896: fix(pluginhelper): fix potential panic in #5849

keon94 commented on code in PR #5896:
URL: https://github.com/apache/incubator-devlake/pull/5896#discussion_r1296042654


##########
backend/server/services/blueprint.go:
##########
@@ -254,16 +254,10 @@ func ReloadBlueprints(c *cron.Cron) errors.Error {
 	}
 	c.Stop()
 	for _, blueprint := range blueprints {
-		if err != nil {

Review Comment:
   err is nil here. L249 already checks it and returns it if not nil



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org