You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/10/23 20:28:25 UTC

[GitHub] [phoenix] stoty commented on pull request #935: PHOENIX-6186 - Store last DDL timestamp in System.Catalog

stoty commented on pull request #935:
URL: https://github.com/apache/phoenix/pull/935#issuecomment-715574319


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 31s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.  |
   ||| _ 4.x Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 32s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  10m 46s |  4.x passed  |
   | +1 :green_heart: |  compile  |   1m 26s |  4.x passed  |
   | +1 :green_heart: |  checkstyle  |   6m 49s |  4.x passed  |
   | +1 :green_heart: |  javadoc  |   1m 48s |  4.x passed  |
   | +0 :ok: |  spotbugs  |   4m 12s |  root in 4.x has 1008 extant spotbugs warnings.  |
   | +0 :ok: |  spotbugs  |   2m 43s |  phoenix-core in 4.x has 954 extant spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m 11s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 30s |  the patch passed  |
   | +1 :green_heart: |  cc  |   1m 30s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 30s |  the patch passed  |
   | -1 :x: |  checkstyle  |   5m 35s |  root: The patch generated 116 new + 14751 unchanged - 41 fixed = 14867 total (was 14792)  |
   | +1 :green_heart: |  prototool  |   0m  1s |  There were no new prototool issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  1s |  The patch has no ill-formed XML file.  |
   | -1 :x: |  javadoc  |   0m 43s |  phoenix-core generated 3 new + 97 unchanged - 3 fixed = 100 total (was 100)  |
   | -1 :x: |  javadoc  |   1m  3s |  root generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132)  |
   | -1 :x: |  spotbugs  |   3m 14s |  phoenix-core generated 1 new + 954 unchanged - 0 fixed = 955 total (was 954)  |
   | -1 :x: |  spotbugs  |   4m 23s |  root generated 1 new + 1008 unchanged - 0 fixed = 1009 total (was 1008)  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 159m 53s |  root in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   1m 26s |  The patch does not generate ASF License warnings.  |
   |  |   | 215m  3s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:phoenix-core |
   |  |  org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 332] |
   | FindBugs | module:root |
   |  |  org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 332] |
   | Failed junit tests | phoenix.end2end.IndexExtendedIT |
   |   | phoenix.end2end.UpgradeIT |
   |   | phoenix.end2end.index.ImmutableIndexIT |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/phoenix/pull/935 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml |
   | uname | Linux cd7751438141 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | 4.x / 605656c |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
   | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt |
   | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt |
   | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
   | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/artifact/yetus-general-check/output/new-spotbugs-root.html |
   | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/artifact/yetus-general-check/output/patch-unit-root.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/testReport/ |
   | Max. process+thread count | 6864 (vs. ulimit of 30000) |
   | modules | C: phoenix-core . U: . |
   | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/3/console |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org