You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Bilgin Ibryam (JIRA)" <ji...@apache.org> on 2007/09/04 18:00:47 UTC
[jira] Created: (OFBIZ-1225) Added a few missing UiLabels to order
component
Added a few missing UiLabels to order component
------------------------------------------------
Key: OFBIZ-1225
URL: https://issues.apache.org/jira/browse/OFBIZ-1225
Project: OFBiz
Issue Type: Bug
Components: order
Affects Versions: SVN trunk
Reporter: Bilgin Ibryam
Priority: Minor
Fix For: SVN trunk
I see some missing labels in order component. I searched in the mailing list but could not find any recommended way to go in these cases.
So i simply copied from EcommerceUiLabels to Order and Party UiLabels.
If it is not the right way, i will change it.
Regards,
Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1225) Added a few missing UiLabels to
order component
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526032 ]
Bilgin Ibryam commented on OFBIZ-1225:
--------------------------------------
Jacques,
i added AccountingEditCreditCard to PartyUiLabels.properties because there are already some Accounting labels and this mislead me.
At the beginning of this issue i asked for a recommended way to go... but now i see that i should ask clear questions for the future.
I replaced OrderPurchaseOrderNumber with OrderPONumber, because the first one is missing in OrderUiLabels and i decided to use the existing OrderPONumber label.
> Added a few missing UiLabels to order component
> ------------------------------------------------
>
> Key: OFBIZ-1225
> URL: https://issues.apache.org/jira/browse/OFBIZ-1225
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ui.patch, ui.patch
>
>
> I see some missing labels in order component. I searched in the mailing list but could not find any recommended way to go in these cases.
> So i simply copied from EcommerceUiLabels to Order and Party UiLabels.
> If it is not the right way, i will change it.
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1225) Added a few missing UiLabels to order
component
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-1225.
----------------------------------
Resolution: Fixed
Thanks Bilgin,
Your patch is in trunk rev. 574072
Actually I did some more work :
I suppressed all instances and references to AccountingNoPaymentMethodsOnFile. I could have done more works like this. For instance why adding AccountingEditCreditCard=Edit Credit Card in PartyUiLabels.properties and not in AccountingUiLabels.properties. I' see that there are already some labels like AccountingCreditCard=Credit Card in this file. But I guess the main reason they were not moved to AccountingUiLabels.properties is because there are also other languages involved. And even if it's only more simple work to do, nobody is really interested (tedious and a bit risky ;o). In case of new labels we should avoid putting them in wrong modules.
Also I kept OrderPurchaseOrderNumber in place of OrderPONumber, was not sure it was better, did you that intentionaly ?
> Added a few missing UiLabels to order component
> ------------------------------------------------
>
> Key: OFBIZ-1225
> URL: https://issues.apache.org/jira/browse/OFBIZ-1225
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ui.patch, ui.patch
>
>
> I see some missing labels in order component. I searched in the mailing list but could not find any recommended way to go in these cases.
> So i simply copied from EcommerceUiLabels to Order and Party UiLabels.
> If it is not the right way, i will change it.
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1225) Added a few missing UiLabels to order
component
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bilgin Ibryam updated OFBIZ-1225:
---------------------------------
Attachment: ui.patch
> Added a few missing UiLabels to order component
> ------------------------------------------------
>
> Key: OFBIZ-1225
> URL: https://issues.apache.org/jira/browse/OFBIZ-1225
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ui.patch, ui.patch
>
>
> I see some missing labels in order component. I searched in the mailing list but could not find any recommended way to go in these cases.
> So i simply copied from EcommerceUiLabels to Order and Party UiLabels.
> If it is not the right way, i will change it.
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1225) Added a few missing UiLabels to order
component
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bilgin Ibryam updated OFBIZ-1225:
---------------------------------
Attachment: ui.patch
> Added a few missing UiLabels to order component
> ------------------------------------------------
>
> Key: OFBIZ-1225
> URL: https://issues.apache.org/jira/browse/OFBIZ-1225
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ui.patch
>
>
> I see some missing labels in order component. I searched in the mailing list but could not find any recommended way to go in these cases.
> So i simply copied from EcommerceUiLabels to Order and Party UiLabels.
> If it is not the right way, i will change it.
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1225) Added a few missing UiLabels to
order component
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525990 ]
Jacques Le Roux commented on OFBIZ-1225:
----------------------------------------
Bilgin,
Did you try to see if labels not from the module (AccountingCompanyNameOnCard in PartyUiLabels.properties for instance) are already existing in the original module (ie AccountingCompanyNameOnCard is already in AccountingUiLabels.properties for instance). Because the idea is to put these labels in their own modules and nomally they will come from there (this is how main-decorator(s) should be set at least when specifing <property-map> tag).
Waiting for your answer before comiting this patch (I will perhaps rework it before also)
Thanks
> Added a few missing UiLabels to order component
> ------------------------------------------------
>
> Key: OFBIZ-1225
> URL: https://issues.apache.org/jira/browse/OFBIZ-1225
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ui.patch
>
>
> I see some missing labels in order component. I searched in the mailing list but could not find any recommended way to go in these cases.
> So i simply copied from EcommerceUiLabels to Order and Party UiLabels.
> If it is not the right way, i will change it.
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1225) Added a few missing UiLabels to
order component
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526383 ]
Jacques Le Roux commented on OFBIZ-1225:
----------------------------------------
FInally I keep both, one is abreviated not the other. Maybe usefull somewhere because of lenght.
> Added a few missing UiLabels to order component
> ------------------------------------------------
>
> Key: OFBIZ-1225
> URL: https://issues.apache.org/jira/browse/OFBIZ-1225
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ui.patch, ui.patch
>
>
> I see some missing labels in order component. I searched in the mailing list but could not find any recommended way to go in these cases.
> So i simply copied from EcommerceUiLabels to Order and Party UiLabels.
> If it is not the right way, i will change it.
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1225) Added a few missing UiLabels to
order component
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526004 ]
Bilgin Ibryam commented on OFBIZ-1225:
--------------------------------------
Jacques,
i searched for existing labels (AccountingCompanyNameOnCard for instance) , but i did it wrong. I should search not AccountingCompanyNameOnCard but its value Company Name on Card.
Now i updated the patch regarding your remarks.
Thanks for clarifications.
> Added a few missing UiLabels to order component
> ------------------------------------------------
>
> Key: OFBIZ-1225
> URL: https://issues.apache.org/jira/browse/OFBIZ-1225
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ui.patch
>
>
> I see some missing labels in order component. I searched in the mailing list but could not find any recommended way to go in these cases.
> So i simply copied from EcommerceUiLabels to Order and Party UiLabels.
> If it is not the right way, i will change it.
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1225) Added a few missing UiLabels to
order component
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-1225:
--------------------------------------
Assignee: Jacques Le Roux
> Added a few missing UiLabels to order component
> ------------------------------------------------
>
> Key: OFBIZ-1225
> URL: https://issues.apache.org/jira/browse/OFBIZ-1225
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ui.patch
>
>
> I see some missing labels in order component. I searched in the mailing list but could not find any recommended way to go in these cases.
> So i simply copied from EcommerceUiLabels to Order and Party UiLabels.
> If it is not the right way, i will change it.
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1225) Added a few missing UiLabels to
order component
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526034 ]
Jacques Le Roux commented on OFBIZ-1225:
----------------------------------------
Thanks for comment Bilgin,
Good point I will look closely to OrderPurchaseOrderNumber and OrderPONumber later
> Added a few missing UiLabels to order component
> ------------------------------------------------
>
> Key: OFBIZ-1225
> URL: https://issues.apache.org/jira/browse/OFBIZ-1225
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ui.patch, ui.patch
>
>
> I see some missing labels in order component. I searched in the mailing list but could not find any recommended way to go in these cases.
> So i simply copied from EcommerceUiLabels to Order and Party UiLabels.
> If it is not the right way, i will change it.
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.