You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/05/22 21:19:25 UTC

Review Request 59467: Document new Fetcher metrics.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59467/
-----------------------------------------------------------

Review request for mesos and Mesos Reviewbot.


Bugs: MESOS-7524
    https://issues.apache.org/jira/browse/MESOS-7524


Repository: mesos


Description
-------

Document new Fetcher metrics.


Diffs
-----

  docs/monitoring.md a027f4905a0e6e41ff4e1348d34fd7aa5f1cbe61 


Diff: https://reviews.apache.org/r/59467/diff/1/


Testing
-------

None.


Thanks,

James Peach

Re: Review Request 59467: Document new Fetcher metrics.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59467/#review175754
-----------------------------------------------------------



Patch looks great!

Reviews applied: [59464, 59466, 59467]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 22, 2017, 9:19 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59467/
> -----------------------------------------------------------
> 
> (Updated May 22, 2017, 9:19 p.m.)
> 
> 
> Review request for mesos and Mesos Reviewbot.
> 
> 
> Bugs: MESOS-7524
>     https://issues.apache.org/jira/browse/MESOS-7524
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Document new Fetcher metrics.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md a027f4905a0e6e41ff4e1348d34fd7aa5f1cbe61 
> 
> 
> Diff: https://reviews.apache.org/r/59467/diff/2/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 59467: Document new Fetcher metrics.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59467/#review177202
-----------------------------------------------------------



Bad review!

Reviews applied: [59467, 59466, 59464]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos Reviewbot


On June 6, 2017, 8:21 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59467/
> -----------------------------------------------------------
> 
> (Updated June 6, 2017, 8:21 p.m.)
> 
> 
> Review request for mesos and Mesos Reviewbot.
> 
> 
> Bugs: MESOS-7524
>     https://issues.apache.org/jira/browse/MESOS-7524
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Document new Fetcher metrics.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md cb2833642e7e41c03c98ea92f7300d156a216a2e 
> 
> 
> Diff: https://reviews.apache.org/r/59467/diff/3/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 59467: Document new Fetcher metrics.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59467/#review177088
-----------------------------------------------------------



Bad review!

Reviews applied: [59467, 59466, 59464]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos Reviewbot Windows


On June 6, 2017, 8:21 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59467/
> -----------------------------------------------------------
> 
> (Updated June 6, 2017, 8:21 p.m.)
> 
> 
> Review request for mesos and Mesos Reviewbot.
> 
> 
> Bugs: MESOS-7524
>     https://issues.apache.org/jira/browse/MESOS-7524
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Document new Fetcher metrics.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md cb2833642e7e41c03c98ea92f7300d156a216a2e 
> 
> 
> Diff: https://reviews.apache.org/r/59467/diff/3/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 59467: Document new Fetcher metrics.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59467/#review178547
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On June 9, 2017, 11:56 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59467/
> -----------------------------------------------------------
> 
> (Updated June 9, 2017, 11:56 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-7524
>     https://issues.apache.org/jira/browse/MESOS-7524
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Document new Fetcher metrics.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md cb2833642e7e41c03c98ea92f7300d156a216a2e 
> 
> 
> Diff: https://reviews.apache.org/r/59467/diff/4/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 59467: Document new Fetcher metrics.

Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59467/
-----------------------------------------------------------

(Updated June 9, 2017, 6:56 p.m.)


Review request for mesos and Joseph Wu.


Changes
-------

Rebased.


Bugs: MESOS-7524
    https://issues.apache.org/jira/browse/MESOS-7524


Repository: mesos


Description
-------

Document new Fetcher metrics.


Diffs (updated)
-----

  docs/monitoring.md cb2833642e7e41c03c98ea92f7300d156a216a2e 


Diff: https://reviews.apache.org/r/59467/diff/4/

Changes: https://reviews.apache.org/r/59467/diff/3-4/


Testing
-------

None.


Thanks,

James Peach

Re: Review Request 59467: Document new Fetcher metrics.

Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59467/
-----------------------------------------------------------

(Updated June 6, 2017, 8:21 p.m.)


Review request for mesos and Mesos Reviewbot.


Bugs: MESOS-7524
    https://issues.apache.org/jira/browse/MESOS-7524


Repository: mesos


Description
-------

Document new Fetcher metrics.


Diffs (updated)
-----

  docs/monitoring.md cb2833642e7e41c03c98ea92f7300d156a216a2e 


Diff: https://reviews.apache.org/r/59467/diff/3/

Changes: https://reviews.apache.org/r/59467/diff/2-3/


Testing
-------

None.


Thanks,

James Peach