You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/17 11:16:17 UTC
[GitHub] [airflow] potiuk opened a new pull request #7196: [AIRFLOW-XXXX]
Review and cleanup integration tests docs.
potiuk opened a new pull request #7196: [AIRFLOW-XXXX] Review and cleanup integration tests docs.
URL: https://github.com/apache/airflow/pull/7196
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk closed pull request #7196: [AIRFLOW-XXXX] Review
and cleanup integration tests docs.
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #7196: [AIRFLOW-XXXX] Review and cleanup integration tests docs.
URL: https://github.com/apache/airflow/pull/7196
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7196: [AIRFLOW-XXXX] Review
and cleanup integration tests docs.
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7196: [AIRFLOW-XXXX] Review and cleanup integration tests docs.
URL: https://github.com/apache/airflow/pull/7196#issuecomment-590092209
The documentation changes have been already implemented in #7388
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7196: [AIRFLOW-XXXX] Review
and cleanup integration tests docs.
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7196: [AIRFLOW-XXXX] Review and cleanup integration tests docs.
URL: https://github.com/apache/airflow/pull/7196#issuecomment-578561379
@efedotova ? Any comments :) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7196: [AIRFLOW-XXXX] Review
and cleanup integration tests docs.
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7196: [AIRFLOW-XXXX] Review and cleanup integration tests docs.
URL: https://github.com/apache/airflow/pull/7196#issuecomment-575585566
Hey @efedotova - here is the PR that you can use to review/improve the integration tests docs :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#7196: [AIRFLOW-XXXX] Review and cleanup integration tests docs.
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7196: [AIRFLOW-XXXX] Review and cleanup integration tests docs.
URL: https://github.com/apache/airflow/pull/7196#discussion_r368289182
##########
File path: CONTRIBUTING.rst
##########
@@ -289,8 +289,8 @@ We support the following types of tests:
* **Integration tests** are available in the Breeze development environment
that is also used for Airflow Travis CI tests. Integration test are special tests that require
- additional services running, such as Postgres,Mysql, Kerberos, etc. These tests are not yet
- clearly marked as integration tests but soon they will be clearly separated by the ``pytest`` annotations.
+ additional services running, such as Postgres,Mysql, Kerberos, etc. They are marked using
Review comment:
```suggestion
additional services running, such as Postgres, Mysql, Kerberos, etc. They are marked using
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services