[GitHub] [beam] alexeyinkin commented on a diff in pull request #25610: [Playground] GetMetadata() endpoint

["alexeyinkin (via GitHub)" <gi...@apache.org>]

alexeyinkin commented on code in PR #25610:
URL: https://github.com/apache/beam/pull/25610#discussion_r1115855752


##########
playground/backend/containers/git-functions.gradle:
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+ext.getGitCommitHash = () -> {
+   def stdout = new ByteArrayOutputStream()
+   exec {
+      executable 'git'

Review Comment:
   I think we should use Kotlin for new endeavors. Or at least simplify possible migration in the future with
   ```suggestion
         executable("git")
   ```



##########
playground/backend/containers/java/build.gradle:
##########
@@ -71,7 +72,9 @@ docker {
   tags containerImageTags()
   buildArgs(['BEAM_VERSION': project.rootProject.hasProperty(["sdk-tag"]) ?
                            project.rootProject["sdk-tag"] :
-                           default_beam_version ])
+                           default_beam_version,
+             'GIT_COMMIT': getGitCommitHash(),
+             'GIT_TIMESTAMP': getGitCommitTimestamp()] )

Review Comment:
   Are there auto-formatters or at least guides? This looks random. Maybe at least add a trailing comma?
   ```suggestion
                'GIT_TIMESTAMP': getGitCommitTimestamp(),
     ])
   ```



##########
playground/api/v1/api.proto:
##########
@@ -314,6 +314,17 @@ message GetSnippetResponse {
   Complexity complexity = 4;
 }
 
+// GetMetadataRequest represents request for runner metadata
+message GetMetadataRequest {}
+
+// GetMetadataResponse contains metadata about the runner
+message GetMetadataResponse {
+  string runner_sdk = 1;
+  string build_commit_hash = 2;
+  string build_commit_timestamp = 3;

Review Comment:
   ```suggestion
     int64 build_commit_seconds_since_epoch = 3;
   ```
   ?
   
   In Dart core these are called `millisecondsSinceEpoch`, `microsecondsSinceEpoch`, etc. to avoid confusion since people nowadays expect varying units of timestamp.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org