You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "Antoine Pitrou (JIRA)" <ji...@apache.org> on 2019/02/07 09:36:00 UTC

[jira] [Commented] (ARROW-4497) [C++] Determine how we want to handle hashing of floating point edge cases

    [ https://issues.apache.org/jira/browse/ARROW-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762514#comment-16762514 ] 

Antoine Pitrou commented on ARROW-4497:
---------------------------------------

Yes, unfortunately it's not obvious which behaviour we want.

I'd say reducing NaN to a single canonical version is reasonable. As for negative zeros it's not obvious. If you get negative zeros in your data they probably deserve distinct treatment...

> [C++] Determine how we want to handle hashing of floating point edge cases
> --------------------------------------------------------------------------
>
>                 Key: ARROW-4497
>                 URL: https://issues.apache.org/jira/browse/ARROW-4497
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Micah Kornfield
>            Priority: Major
>              Labels: analytics
>             Fix For: 0.14.0
>
>
> We should document expected behavior or implement improvements to hashing floating point code:
> 1.  -0.0 and 0.0 (should these be collapsed to 0.0)
> 2. NaN (Should we reduce to a single canonical version).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)