[GitHub] [doris] englefly commented on a diff in pull request #20789: [improvement](nereids) prune hash join output slot ids list

["englefly (via GitHub)" <gi...@apache.org>]

englefly commented on code in PR #20789:
URL: https://github.com/apache/doris/pull/20789#discussion_r1244578302


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -1691,17 +1717,26 @@ public PlanFragment visitPhysicalProject(PhysicalProject<? extends Plan> project
             JoinNodeBase hashJoinNode = (JoinNodeBase) inputPlanNode;
             hashJoinNode.setvOutputTupleDesc(tupleDescriptor);
             hashJoinNode.setvSrcToOutputSMap(execExprList);
+            // prune the hashOutputSlotIds
+            if (hashJoinNode instanceof HashJoinNode) {

Review Comment:
   Nest loop join also need this prune.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org