You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/06 12:03:43 UTC

[GitHub] [activemq-artemis] luisalves00 opened a new pull request #3436: ARTEMIS-2876: Port artemis-junit @Rule to junit5 extensions

luisalves00 opened a new pull request #3436:
URL: https://github.com/apache/activemq-artemis/pull/3436


   Please review a possible solution for ARTEMIS-2876. The module name allow backwards compatibility.
   
   artemis-junit-all - hold the core logic that can be used by both junit4 (@Role) and junit5 (@RegisterExtension). Possibly used by TestNG if needed. (don't depend on junit)
   artemis-junit - keep only the junit4 @Rule implementation  (depend only junit4)
   artemis-junit-extensions - same as artemis-junit but for Junit5.  (depend only junit5) - will allow junit5 only projects to include only junit5.
   
   If accepted I still need to add proper javadoc, some method encapsulation and update the documentation. Also, better names for classes and modules are welcomed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] luisalves00 commented on pull request #3436: ARTEMIS-2876: Port artemis-junit @Rule to junit5 extensions

Posted by GitBox <gi...@apache.org>.
luisalves00 commented on pull request #3436:
URL: https://github.com/apache/activemq-artemis/pull/3436#issuecomment-774986959


   I like the sub-modules names proposal, in fact they are similar to the ones I originally had planned, but renamed them to make it retro-compatible. If it's okay to do the breaking change I can modify the modules. Using this sub-module strategy it might even be compatible, but I think junit5 API will be pulled...I'll submit another proposal next weekend. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] jbertram commented on pull request #3436: ARTEMIS-2876: Port artemis-junit @Rule to junit5 extensions

Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3436:
URL: https://github.com/apache/activemq-artemis/pull/3436#issuecomment-774851296


   I think that a better approach might be to create 3 sub-modules under `artemis-junit`. You could have `artemis-junit-4`, `artemis-junit-5`, and then `artemis-junit-commons` for all the bits they share. I'm not sure what this would mean for backwards compatibility since the Maven coordinates would change for existing users. Perhaps there's some Maven magic we could do to get around that. Or perhaps we could do this change in a major version.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org