You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Neal Richardson (Jira)" <ji...@apache.org> on 2021/07/29 19:24:00 UTC

[jira] [Created] (ARROW-13493) [C++] Anonymous structs are a GNU convention

Neal Richardson created ARROW-13493:
---------------------------------------

             Summary: [C++] Anonymous structs are a GNU convention
                 Key: ARROW-13493
                 URL: https://issues.apache.org/jira/browse/ARROW-13493
             Project: Apache Arrow
          Issue Type: Bug
          Components: C++, R
            Reporter: Neal Richardson
             Fix For: 6.0.0


CRAN reports on 5.0.0:

{code}
checking whether package ‘arrow’ can be installed ... [43m/20m] WARNING
Found the following significant warnings:
  /data/gannet/ripley/R/packages/tests-clang/arrow/libarrow/arrow-5.0.0/include/arrow/util/bitmap_reader.h:242:5: warning: anonymous structs are a GNU extension [-Wgnu-anonymous-struct]
  /data/gannet/ripley/R/packages/tests-clang/arrow/libarrow/arrow-5.0.0/include/arrow/util/bitmap_reader.h:242:5: warning: anonymous types declared in an anonymous union are an extension [-Wnested-anon-types]
  /data/gannet/ripley/R/packages/tests-clang/arrow/libarrow/arrow-5.0.0/include/arrow/util/bitmap_writer.h:263:5: warning: anonymous structs are a GNU extension [-Wgnu-anonymous-struct]
  /data/gannet/ripley/R/packages/tests-clang/arrow/libarrow/arrow-5.0.0/include/arrow/util/bitmap_writer.h:263:5: warning: anonymous types declared in an anonymous union are an extension [-Wnested-anon-types]
See https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/arrow-00install.html for details.
{code}

https://github.com/apache/arrow/blob/apache-arrow-5.0.0/cpp/src/arrow/util/bitmap_reader.h#L242-L247
https://github.com/apache/arrow/blob/apache-arrow-5.0.0/cpp/src/arrow/util/bitmap_writer.h#L263-L268

This change was introduced in ARROW-13010 (cc [~niranda])

Aside from the fix, I'm not sure which of the build settings on https://www.stats.ox.ac.uk/pub/bdr/Rconfig/r-devel-linux-x86_64-fedora-clang is missing from our `fedora-clang-devel` build we test on nightly, but we should figure it out (or work with the r-hub maintainers on making a better base image).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)