You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org> on 2016/10/12 16:41:20 UTC
[jira] [Commented] (KARAF-4767) Decanter: collectors and appenders
can't be re-used without default configuration
[ https://issues.apache.org/jira/browse/KARAF-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569195#comment-15569195 ]
Jean-Baptiste Onofré commented on KARAF-4767:
---------------------------------------------
By the way, I already created a Jira regarding the JMX appender and already started for this one.
> Decanter: collectors and appenders can't be re-used without default configuration
> ---------------------------------------------------------------------------------
>
> Key: KARAF-4767
> URL: https://issues.apache.org/jira/browse/KARAF-4767
> Project: Karaf
> Issue Type: Bug
> Components: decanter
> Affects Versions: decanter-1.2.0
> Reporter: Achim Nierbeck
> Assignee: Achim Nierbeck
> Fix For: decanter-1.3.0
>
>
> Right now the jmx collector and various appenders can't be re-used without the default configs, those features should be split into the current one which references a *-core feature. This way it's easier to re-use the jmx collector or the elasticsearch appender ...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jira] [Work started] (KARAF-4767) Decanter: collectors and
appenders can't be re-used without default configuration
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Agree, but it requires a Karaf change. So, in the mean time, I agree
with Achim's change.
Regards
JB
On 10/13/2016 09:14 AM, Christian Schneider wrote:
> I see the need to deploy features with your own config.. or maybe even
> no config at all to install but not activate the decanter module.
> If there is no other way I agree with this change.
>
> It sounds a bit like a generic problem though. On one hand we have the
> requirement for a very nice experience when a user first installs
> decanter. So
> we provide the default configs. On the other hand for production you
> typically want a different config anyway so the default configs there
> rather hurt.
>
> One generic solution might be to have a feature option config with
> default true. So the normal case would be unchanged and still Achim
> could use it like this:
>
> <feature name="${project.artifactId}" version="${project.version}">
> <feature dependency="true">scr</feature>
> <feature dependency="true"
> config="false">decanter-appender-elasticsearch-rest</feature>
> <feature dependency="true"
> config="false">decanter-collector-jmx</feature>
> <feature dependency="true"
> config="false">decanter-collector-process</feature>
> <bundle>mvn:${project.groupId}/Decanter-Module/${project.version}</bundle>
> <configfile
> finalname="/etc/org.apache.karaf.decanter.appender.elasticsearch.rest.cfg">mvn:de.nierbeck.karaf.decanter/Decanter-Module/${project.version}/cfg</configfile>
>
> </feature>
>
> WDYT?
>
> This is not a quick solution though as it requires a changes in karaf
> and a new karaf version. So lets have the core features for now but
> later eventually remove them again.
>
> Christian
>
> On 13.10.2016 08:28, Achim Nierbeck wrote:
>> Hi Christian,
>>
>> yes it's actually more like double the features, as it's really hard to
>> seperate the config from the modules for re-usage.
>> A concrete example for this can be found here [1].
>>
>> regards, Achim
>>
>> [1] -
>> https://github.com/ANierbeck/Karaf-Decanter-Runtime/blob/master/Decanter-Feature/src/main/feature/feature.xml
>>
>
--
Jean-Baptiste Onofr�
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: [jira] [Work started] (KARAF-4767) Decanter: collectors and
appenders can't be re-used without default configuration
Posted by Christian Schneider <ch...@die-schneider.net>.
I see the need to deploy features with your own config.. or maybe even
no config at all to install but not activate the decanter module.
If there is no other way I agree with this change.
It sounds a bit like a generic problem though. On one hand we have the
requirement for a very nice experience when a user first installs
decanter. So
we provide the default configs. On the other hand for production you
typically want a different config anyway so the default configs there
rather hurt.
One generic solution might be to have a feature option config with
default true. So the normal case would be unchanged and still Achim
could use it like this:
<feature name="${project.artifactId}" version="${project.version}">
<feature dependency="true">scr</feature>
<feature dependency="true"
config="false">decanter-appender-elasticsearch-rest</feature>
<feature dependency="true"
config="false">decanter-collector-jmx</feature>
<feature dependency="true"
config="false">decanter-collector-process</feature>
<bundle>mvn:${project.groupId}/Decanter-Module/${project.version}</bundle>
<configfile
finalname="/etc/org.apache.karaf.decanter.appender.elasticsearch.rest.cfg">mvn:de.nierbeck.karaf.decanter/Decanter-Module/${project.version}/cfg</configfile>
</feature>
WDYT?
This is not a quick solution though as it requires a changes in karaf
and a new karaf version. So lets have the core features for now but
later eventually remove them again.
Christian
On 13.10.2016 08:28, Achim Nierbeck wrote:
> Hi Christian,
>
> yes it's actually more like double the features, as it's really hard to
> seperate the config from the modules for re-usage.
> A concrete example for this can be found here [1].
>
> regards, Achim
>
> [1] -
> https://github.com/ANierbeck/Karaf-Decanter-Runtime/blob/master/Decanter-Feature/src/main/feature/feature.xml
--
Christian Schneider
http://www.liquid-reality.de
Open Source Architect
http://www.talend.com
Re: [jira] [Work started] (KARAF-4767) Decanter: collectors and
appenders can't be re-used without default configuration
Posted by Achim Nierbeck <bc...@googlemail.com>.
Hi Christian,
yes it's actually more like double the features, as it's really hard to
seperate the config from the modules for re-usage.
A concrete example for this can be found here [1].
regards, Achim
[1] -
https://github.com/ANierbeck/Karaf-Decanter-Runtime/blob/master/Decanter-Feature/src/main/feature/feature.xml
2016-10-13 7:42 GMT+02:00 Jean-Baptiste Onofré <jb...@nanthrax.net>:
> Basically, Achim wants to use the Decanter features without the default
> cfg.
>
> For instance, today, when you install the decanter-collector-jmx feature,
> it installs local-jmx.cfg configuration file by default.
>
> Achim doesn't want the default config, only the "core" features (bundles)
> and define his own configuration.
>
> Regards
> JB
>
>
> On 10/13/2016 07:14 AM, Christian Schneider wrote:
>
>> This change creates a lot of new features. I do not yet understand the
>> reasoning behind it.
>> Can you explain?
>>
>> Christian
>>
>> 2016-10-12 19:59 GMT+02:00 Achim Nierbeck <bc...@googlemail.com>:
>>
>> Working on it, but been in a hurry to complete. Will be done tonight
>>>
>>> Am Mittwoch, 12. Oktober 2016 schrieb Jean-Baptiste Onofré (JIRA) :
>>>
>>>
>>>> [ https://issues.apache.org/jira/browse/KARAF-4767?page=
>>>> com.atlassian.jira.plugin.system.issuetabpanels:comment-
>>>> tabpanel&focusedCommentId=15569195#comment-15569195 ]
>>>>
>>>> Jean-Baptiste Onofré commented on KARAF-4767:
>>>> ---------------------------------------------
>>>>
>>>> By the way, I already created a Jira regarding the JMX appender and
>>>> already started for this one.
>>>>
>>>> Decanter: collectors and appenders can't be re-used without default
>>>>>
>>>> configuration
>>>>
>>>>> ------------------------------------------------------------
>>>>>
>>>> ---------------------
>>>>
>>>>>
>>>>> Key: KARAF-4767
>>>>> URL: https://issues.apache.org/jira/browse/KARAF-4767
>>>>> Project: Karaf
>>>>> Issue Type: Bug
>>>>> Components: decanter
>>>>> Affects Versions: decanter-1.2.0
>>>>> Reporter: Achim Nierbeck
>>>>> Assignee: Achim Nierbeck
>>>>> Fix For: decanter-1.3.0
>>>>>
>>>>>
>>>>> Right now the jmx collector and various appenders can't be re-used
>>>>>
>>>> without the default configs, those features should be split into the
>>>> current one which references a *-core feature. This way it's easier to
>>>> re-use the jmx collector or the elasticsearch appender ...
>>>>
>>>>
>>>>
>>>> --
>>>> This message was sent by Atlassian JIRA
>>>> (v6.3.4#6332)
>>>>
>>>>
>>>
>>> --
>>>
>>> Apache Member
>>> Apache Karaf <http://karaf.apache.org/> Committer & PMC
>>> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer
>>> &
>>> Project Lead
>>> blog <http://notizblog.nierbeck.de/>
>>> Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS>
>>>
>>> Software Architect / Project Manager / Scrum Master
>>>
>>>
>>
>>
>>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>
--
Apache Member
Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer &
Project Lead
blog <http://notizblog.nierbeck.de/>
Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS>
Software Architect / Project Manager / Scrum Master
Re: [jira] [Work started] (KARAF-4767) Decanter: collectors and
appenders can't be re-used without default configuration
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Basically, Achim wants to use the Decanter features without the default cfg.
For instance, today, when you install the decanter-collector-jmx
feature, it installs local-jmx.cfg configuration file by default.
Achim doesn't want the default config, only the "core" features
(bundles) and define his own configuration.
Regards
JB
On 10/13/2016 07:14 AM, Christian Schneider wrote:
> This change creates a lot of new features. I do not yet understand the
> reasoning behind it.
> Can you explain?
>
> Christian
>
> 2016-10-12 19:59 GMT+02:00 Achim Nierbeck <bc...@googlemail.com>:
>
>> Working on it, but been in a hurry to complete. Will be done tonight
>>
>> Am Mittwoch, 12. Oktober 2016 schrieb Jean-Baptiste Onofr� (JIRA) :
>>
>>>
>>> [ https://issues.apache.org/jira/browse/KARAF-4767?page=
>>> com.atlassian.jira.plugin.system.issuetabpanels:comment-
>>> tabpanel&focusedCommentId=15569195#comment-15569195 ]
>>>
>>> Jean-Baptiste Onofr� commented on KARAF-4767:
>>> ---------------------------------------------
>>>
>>> By the way, I already created a Jira regarding the JMX appender and
>>> already started for this one.
>>>
>>>> Decanter: collectors and appenders can't be re-used without default
>>> configuration
>>>> ------------------------------------------------------------
>>> ---------------------
>>>>
>>>> Key: KARAF-4767
>>>> URL: https://issues.apache.org/jira/browse/KARAF-4767
>>>> Project: Karaf
>>>> Issue Type: Bug
>>>> Components: decanter
>>>> Affects Versions: decanter-1.2.0
>>>> Reporter: Achim Nierbeck
>>>> Assignee: Achim Nierbeck
>>>> Fix For: decanter-1.3.0
>>>>
>>>>
>>>> Right now the jmx collector and various appenders can't be re-used
>>> without the default configs, those features should be split into the
>>> current one which references a *-core feature. This way it's easier to
>>> re-use the jmx collector or the elasticsearch appender ...
>>>
>>>
>>>
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.3.4#6332)
>>>
>>
>>
>> --
>>
>> Apache Member
>> Apache Karaf <http://karaf.apache.org/> Committer & PMC
>> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer &
>> Project Lead
>> blog <http://notizblog.nierbeck.de/>
>> Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS>
>>
>> Software Architect / Project Manager / Scrum Master
>>
>
>
>
--
Jean-Baptiste Onofr�
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: [jira] [Work started] (KARAF-4767) Decanter: collectors and
appenders can't be re-used without default configuration
Posted by Christian Schneider <ch...@die-schneider.net>.
This change creates a lot of new features. I do not yet understand the
reasoning behind it.
Can you explain?
Christian
2016-10-12 19:59 GMT+02:00 Achim Nierbeck <bc...@googlemail.com>:
> Working on it, but been in a hurry to complete. Will be done tonight
>
> Am Mittwoch, 12. Oktober 2016 schrieb Jean-Baptiste Onofré (JIRA) :
>
> >
> > [ https://issues.apache.org/jira/browse/KARAF-4767?page=
> > com.atlassian.jira.plugin.system.issuetabpanels:comment-
> > tabpanel&focusedCommentId=15569195#comment-15569195 ]
> >
> > Jean-Baptiste Onofré commented on KARAF-4767:
> > ---------------------------------------------
> >
> > By the way, I already created a Jira regarding the JMX appender and
> > already started for this one.
> >
> > > Decanter: collectors and appenders can't be re-used without default
> > configuration
> > > ------------------------------------------------------------
> > ---------------------
> > >
> > > Key: KARAF-4767
> > > URL: https://issues.apache.org/jira/browse/KARAF-4767
> > > Project: Karaf
> > > Issue Type: Bug
> > > Components: decanter
> > > Affects Versions: decanter-1.2.0
> > > Reporter: Achim Nierbeck
> > > Assignee: Achim Nierbeck
> > > Fix For: decanter-1.3.0
> > >
> > >
> > > Right now the jmx collector and various appenders can't be re-used
> > without the default configs, those features should be split into the
> > current one which references a *-core feature. This way it's easier to
> > re-use the jmx collector or the elasticsearch appender ...
> >
> >
> >
> > --
> > This message was sent by Atlassian JIRA
> > (v6.3.4#6332)
> >
>
>
> --
>
> Apache Member
> Apache Karaf <http://karaf.apache.org/> Committer & PMC
> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer &
> Project Lead
> blog <http://notizblog.nierbeck.de/>
> Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS>
>
> Software Architect / Project Manager / Scrum Master
>
--
--
Christian Schneider
http://www.liquid-reality.de
<https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46&URL=http%3a%2f%2fwww.liquid-reality.de>
Open Source Architect
http://www.talend.com
<https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46&URL=http%3a%2f%2fwww.talend.com>
Re: [jira] [Work started] (KARAF-4767) Decanter: collectors and
appenders can't be re-used without default configuration
Posted by Achim Nierbeck <bc...@googlemail.com>.
Working on it, but been in a hurry to complete. Will be done tonight
Am Mittwoch, 12. Oktober 2016 schrieb Jean-Baptiste Onofré (JIRA) :
>
> [ https://issues.apache.org/jira/browse/KARAF-4767?page=
> com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel&focusedCommentId=15569195#comment-15569195 ]
>
> Jean-Baptiste Onofré commented on KARAF-4767:
> ---------------------------------------------
>
> By the way, I already created a Jira regarding the JMX appender and
> already started for this one.
>
> > Decanter: collectors and appenders can't be re-used without default
> configuration
> > ------------------------------------------------------------
> ---------------------
> >
> > Key: KARAF-4767
> > URL: https://issues.apache.org/jira/browse/KARAF-4767
> > Project: Karaf
> > Issue Type: Bug
> > Components: decanter
> > Affects Versions: decanter-1.2.0
> > Reporter: Achim Nierbeck
> > Assignee: Achim Nierbeck
> > Fix For: decanter-1.3.0
> >
> >
> > Right now the jmx collector and various appenders can't be re-used
> without the default configs, those features should be split into the
> current one which references a *-core feature. This way it's easier to
> re-use the jmx collector or the elasticsearch appender ...
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>
--
Apache Member
Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer &
Project Lead
blog <http://notizblog.nierbeck.de/>
Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS>
Software Architect / Project Manager / Scrum Master