You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/15 01:03:10 UTC
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38609: [SPARK-40593][BUILD][CONNECT] Make user can build and test `connect` module by specifying the user-defined `protoc` and `protoc-gen-grpc-java`
HyukjinKwon commented on code in PR #38609:
URL: https://github.com/apache/spark/pull/38609#discussion_r1022213304
##########
connector/connect/README.md:
##########
@@ -24,7 +24,30 @@ or
```bash
./build/sbt -Phive clean package
```
-
+
+### Build with user-defined `protoc` and `protoc-gen-grpc-java`
Review Comment:
I would add an example in which we need this custom compilation. For example, CentOS 5 and 6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org