You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by do...@apache.org on 2009/05/04 00:55:57 UTC
svn commit: r771141 - in /ofbiz/trunk/applications:
accounting/src/org/ofbiz/accounting/thirdparty/valuelink/
manufacturing/src/org/ofbiz/manufacturing/bom/
order/src/org/ofbiz/order/shoppinglist/ product/src/
product/src/org/ofbiz/product/product/
Author: doogie
Date: Sun May 3 22:55:57 2009
New Revision: 771141
URL: http://svn.apache.org/viewvc?rev=771141&view=rev
Log:
Fix some more append(""+"") stuff.
Modified:
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/valuelink/ValueLinkApi.java
ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/bom/BOMNode.java
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java
ofbiz/trunk/applications/product/src/ShipmentScaleApplet.java
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java
Modified: ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/valuelink/ValueLinkApi.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/valuelink/ValueLinkApi.java?rev=771141&r1=771140&r2=771141&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/valuelink/ValueLinkApi.java (original)
+++ ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/valuelink/ValueLinkApi.java Sun May 3 22:55:57 2009
@@ -359,37 +359,37 @@
BigInteger y = publicKey.getY();
byte[] yBytes = y.toByteArray();
String yHex = StringUtil.toHexString(yBytes);
- buf.append("======== Begin Public Key (Y @ " + yBytes.length + " / " + yHex.length() + ") ========\n");
- buf.append(yHex + "\n");
+ buf.append("======== Begin Public Key (Y @ ").append(yBytes.length).append(" / ").append(yHex.length()).append(") ========\n");
+ buf.append(yHex).append("\n");
buf.append("======== End Public Key ========\n\n");
// private key (just X)
BigInteger x = privateKey.getX();
byte[] xBytes = x.toByteArray();
String xHex = StringUtil.toHexString(xBytes);
- buf.append("======== Begin Private Key (X @ " + xBytes.length + " / " + xHex.length() + ") ========\n");
- buf.append(xHex + "\n");
+ buf.append("======== Begin Private Key (X @ ").append(xBytes.length).append(" / ").append(xHex.length()).append(") ========\n");
+ buf.append(xHex).append("\n");
buf.append("======== End Private Key ========\n\n");
// private key (full)
byte[] privateBytes = privateKey.getEncoded();
String privateHex = StringUtil.toHexString(privateBytes);
- buf.append("======== Begin Private Key (Full @ " + privateBytes.length + " / " + privateHex.length() + ") ========\n");
- buf.append(privateHex + "\n");
+ buf.append("======== Begin Private Key (Full @ ").append(privateBytes.length).append(" / ").append(privateHex.length()).append(") ========\n");
+ buf.append(privateHex).append("\n");
buf.append("======== End Private Key ========\n\n");
}
if (kekBytes != null) {
- buf.append("======== Begin KEK (" + kekBytes.length + ") ========\n");
- buf.append(StringUtil.toHexString(kekBytes) + "\n");
+ buf.append("======== Begin KEK (").append(kekBytes.length).append(") ========\n");
+ buf.append(StringUtil.toHexString(kekBytes)).append("\n");
buf.append("======== End KEK ========\n\n");
- buf.append("======== Begin KEK (DES) (" + loadKekBytes.length + ") ========\n");
- buf.append(StringUtil.toHexString(loadKekBytes) + "\n");
+ buf.append("======== Begin KEK (DES) (").append(loadKekBytes.length).append(") ========\n");
+ buf.append(StringUtil.toHexString(loadKekBytes)).append("\n");
buf.append("======== End KEK (DES) ========\n\n");
- buf.append("======== Begin KEK Test (" + kekTestC.length + ") ========\n");
- buf.append(StringUtil.toHexString(kekTestC) + "\n");
+ buf.append("======== Begin KEK Test (").append(kekTestC.length).append(") ========\n");
+ buf.append(StringUtil.toHexString(kekTestC)).append("\n");
buf.append("======== End KEK Test ========\n\n");
} else {
Debug.logError("KEK came back empty", module);
Modified: ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/bom/BOMNode.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/bom/BOMNode.java?rev=771141&r1=771140&r2=771141&view=diff
==============================================================================
--- ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/bom/BOMNode.java (original)
+++ ofbiz/trunk/applications/manufacturing/src/org/ofbiz/manufacturing/bom/BOMNode.java Sun May 3 22:55:57 2009
@@ -384,7 +384,7 @@
}
sb.append(product.get("productId"));
sb.append(" - ");
- sb.append("" + quantity);
+ sb.append(quantity);
GenericValue oneChild = null;
BOMNode oneChildNode = null;
depth++;
Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java?rev=771141&r1=771140&r2=771141&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java (original)
+++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppinglist/ShoppingListEvents.java Sun May 3 22:55:57 2009
@@ -296,17 +296,17 @@
}
Map messageMap = UtilMisc.toMap("productId", productId);
errMsg = UtilProperties.getMessage(resource_error,"shoppinglistevents.added_product_to_cart", messageMap, cart.getLocale());
- eventMessage.append(errMsg + "\n");
+ eventMessage.append(errMsg).append("\n");
} catch (CartItemModifyException e) {
Debug.logWarning(e, UtilProperties.getMessage(resource_error,"OrderProblemsAddingItemFromListToCart", cart.getLocale()));
Map messageMap = UtilMisc.toMap("productId", productId);
errMsg = UtilProperties.getMessage(resource_error,"shoppinglistevents.problem_adding_product_to_cart", messageMap, cart.getLocale());
- eventMessage.append(errMsg + "\n");
+ eventMessage.append(errMsg).append("\n");
} catch (ItemNotFoundException e) {
Debug.logWarning(e, UtilProperties.getMessage(resource_error,"OrderProductNotFound", cart.getLocale()));
Map messageMap = UtilMisc.toMap("productId", productId);
errMsg = UtilProperties.getMessage(resource_error,"shoppinglistevents.problem_adding_product_to_cart", messageMap, cart.getLocale());
- eventMessage.append(errMsg + "\n");
+ eventMessage.append(errMsg).append("\n");
}
}
Modified: ofbiz/trunk/applications/product/src/ShipmentScaleApplet.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/ShipmentScaleApplet.java?rev=771141&r1=771140&r2=771141&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/src/ShipmentScaleApplet.java (original)
+++ ofbiz/trunk/applications/product/src/ShipmentScaleApplet.java Sun May 3 22:55:57 2009
@@ -133,7 +133,7 @@
} else {
inputBuffer.append((char)newData);
}
- //inputBuffer.append("(" + newData + ")");
+ //inputBuffer.append("(").append(newData).append(")");
}
} catch (IOException ex) {
Modified: ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java?rev=771141&r1=771140&r2=771141&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java (original)
+++ ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java Sun May 3 22:55:57 2009
@@ -1263,7 +1263,7 @@
GenericValue productFeature = delegator.findByPrimaryKeyCache("ProductFeature", UtilMisc.toMap("productFeatureId", featureId));
GenericValue productFeatureType = productFeature == null ? null : productFeature.getRelatedOneCache("ProductFeatureType");
if (productFeatureType == null) {
- infoOut.append(UtilProperties.getMessage(resource, "ProductFeature", locale)+": ");
+ infoOut.append(UtilProperties.getMessage(resource, "ProductFeature", locale)).append(": ");
} else {
infoOut.append(productFeatureType.getString("description"));
infoOut.append(": ");