You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by chiba3 <gi...@git.apache.org> on 2018/11/10 17:03:15 UTC

[GitHub] storm pull request #2904: add indent to log4j2 xml files

GitHub user chiba3 opened a pull request:

    https://github.com/apache/storm/pull/2904

    add indent to log4j2 xml files

    Only indent changes. add indent after configuration block.
    
    before
    ```
    <configuration monitorInterval="60" shutdownHook="disable">	
    <block>
    
    </block>
    </configuration>
    ```
    
    after
    ```
    <configuration monitorInterval="60" shutdownHook="disable">	
        <block>
    
        </block>
    </configuration>
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chiba3/storm add-indent-log4j2-xml

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2904.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2904
    
----
commit 00cd667a4cce14f716cc9480dfad71ec0e029a3f
Author: jenkins <je...@...>
Date:   2018-11-10T16:49:18Z

    add indent to log4j2 xml files

----


---

[GitHub] storm pull request #2904: add indent to log4j2 xml files

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2904


---

[GitHub] storm issue #2904: add indent to log4j2 xml files

Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2904
  
    Thanks @chiba3, merged to master.


---

[GitHub] storm issue #2904: add indent to log4j2 xml files

Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2904
  
    +1. I think this is akin to a documentation change (formatting only), so doesn't need an issue filed for it.


---