You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Guozhang Wang <gu...@linkedin.com> on 2014/05/07 00:56:23 UTC
Review Request 21134: Fix KAFKA-1432: follow-up on producer shutdown issue
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21134/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1432
https://issues.apache.org/jira/browse/KAFKA-1432
Repository: kafka
Description
-------
KAFKA-1432 Follow-up
Diffs
-----
core/src/main/scala/kafka/tools/MirrorMaker.scala 12fa7979251da55b83564b25cbc8bca1f58ce387
Diff: https://reviews.apache.org/r/21134/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 21134: Fix KAFKA-1432: follow-up on producer shutdown
issue
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21134/#review42413
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On May 6, 2014, 11:05 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21134/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 11:05 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1432
> https://issues.apache.org/jira/browse/KAFKA-1432
>
>
> Repository: kafka
>
>
> Description
> -------
>
> wait on producer shutdown latch instead of consumers
>
>
> KAFKA-1432 Follow-up
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/MirrorMaker.scala 12fa7979251da55b83564b25cbc8bca1f58ce387
>
> Diff: https://reviews.apache.org/r/21134/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 21134: Fix KAFKA-1432: follow-up on producer shutdown
issue
Posted by Guozhang Wang <gu...@linkedin.com>.
> On May 6, 2014, 11:19 p.m., Neha Narkhede wrote:
> > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 166
> > <https://reviews.apache.org/r/21134/diff/1/?file=575738#file575738line166>
> >
> > This is a good catch. I'm wondering if we need both though. Shouldn't it suffice to call producerThreads.foreach(_awaitShutdown)?
Hey Neha,
Yeah I changed that in the updated patch.
- Guozhang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21134/#review42368
-----------------------------------------------------------
On May 6, 2014, 11:05 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21134/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 11:05 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1432
> https://issues.apache.org/jira/browse/KAFKA-1432
>
>
> Repository: kafka
>
>
> Description
> -------
>
> wait on producer shutdown latch instead of consumers
>
>
> KAFKA-1432 Follow-up
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/MirrorMaker.scala 12fa7979251da55b83564b25cbc8bca1f58ce387
>
> Diff: https://reviews.apache.org/r/21134/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 21134: Fix KAFKA-1432: follow-up on producer shutdown
issue
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21134/#review42368
-----------------------------------------------------------
core/src/main/scala/kafka/tools/MirrorMaker.scala
<https://reviews.apache.org/r/21134/#comment76147>
This is a good catch. I'm wondering if we need both though. Shouldn't it suffice to call producerThreads.foreach(_awaitShutdown)?
- Neha Narkhede
On May 6, 2014, 11:05 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21134/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 11:05 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1432
> https://issues.apache.org/jira/browse/KAFKA-1432
>
>
> Repository: kafka
>
>
> Description
> -------
>
> wait on producer shutdown latch instead of consumers
>
>
> KAFKA-1432 Follow-up
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/MirrorMaker.scala 12fa7979251da55b83564b25cbc8bca1f58ce387
>
> Diff: https://reviews.apache.org/r/21134/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 21134: Fix KAFKA-1432: follow-up on producer shutdown
issue
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21134/
-----------------------------------------------------------
(Updated May 6, 2014, 11:05 p.m.)
Review request for kafka.
Bugs: KAFKA-1432
https://issues.apache.org/jira/browse/KAFKA-1432
Repository: kafka
Description (updated)
-------
wait on producer shutdown latch instead of consumers
KAFKA-1432 Follow-up
Diffs (updated)
-----
core/src/main/scala/kafka/tools/MirrorMaker.scala 12fa7979251da55b83564b25cbc8bca1f58ce387
Diff: https://reviews.apache.org/r/21134/diff/
Testing
-------
Thanks,
Guozhang Wang