You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/11 15:49:55 UTC

[GitHub] [incubator-druid] leventov commented on a change in pull request #7933: #7858 Throwing UnsupportedOperationException from ImmutableDruidDataSource's equals() and hashCode() methods

leventov commented on a change in pull request #7933: #7858 Throwing UnsupportedOperationException from ImmutableDruidDataSource's equals() and hashCode() methods
URL: https://github.com/apache/incubator-druid/pull/7933#discussion_r302617638
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/client/ImmutableDruidDataSource.java
 ##########
 @@ -120,8 +120,39 @@ public String toString()
            + "'}";
   }
 
+  /**
+   *
+   * ImmutableDruidDataSource should be considered a container, not a data class.
+   * The idea is the same as behind prohibiting/limiting equals() (and therefore usage as HashSet/HashMap keys) of DataSegment: see #6358.
 
 Review comment:
   Use `https://github.com/apache/incubator-druid/issues/6358` instead of `#6358`. People cannot follow `#6358` when they see this comment in IDE.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org