You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/22 23:07:34 UTC
[GitHub] [airflow] jedcunningham opened a new pull request #19759: Fix duplicate changelog entries
jedcunningham opened a new pull request #19759:
URL: https://github.com/apache/airflow/pull/19759
I noticed we had a number of duplicated entries in our changelogs. This removes then and also adds a pre-commit hook to prevent new duplicate entries from being added accidentally in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19759: Fix duplicate changelog entries
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19759:
URL: https://github.com/apache/airflow/pull/19759#issuecomment-976011031
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #19759: Fix duplicate changelog entries
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #19759:
URL: https://github.com/apache/airflow/pull/19759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19759: Fix duplicate changelog entries
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19759:
URL: https://github.com/apache/airflow/pull/19759#discussion_r754938560
##########
File path: .pre-commit-config.yaml
##########
@@ -690,6 +690,12 @@ repos:
files: ^airflow/www/static/js/
entry: scripts/ci/static_checks/www_lint.sh
pass_filenames: false
+ - id: changelog-duplicates
+ name: Check changelogs for duplicate entries
+ language: python
+ files: CHANGELOG.txt$|CHANGELOG.rst$
Review comment:
Need to escape `.` because this is regex
```suggestion
files: CHANGELOG\.txt$|CHANGELOG\.rst$
```
##########
File path: CHANGELOG.txt
##########
@@ -2755,8 +2726,7 @@ Improvement
- [AIRFLOW-3591] Fix start date, end date, duration for rescheduled tasks (#4502)
- [AIRFLOW-3709] Validate `allowed_states` for ExternalTaskSensor (#4536)
- [AIRFLOW-3522] Add support for sending Slack attachments (#4332)
-- [AIRFLOW-3569] Add "Trigger DAG" button in DAG page (/www only) (#4373)
-- [AIRFLOW-3569] Add "Trigger DAG" button in DAG page (/www_rbac only) (#4373)
+- [AIRFLOW-3569] Add "Trigger DAG" button in DAG page (#4373)
Review comment:
Was this one fixed manually?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #19759: Fix duplicate changelog entries
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #19759:
URL: https://github.com/apache/airflow/pull/19759#discussion_r755145251
##########
File path: CHANGELOG.txt
##########
@@ -2755,8 +2726,7 @@ Improvement
- [AIRFLOW-3591] Fix start date, end date, duration for rescheduled tasks (#4502)
- [AIRFLOW-3709] Validate `allowed_states` for ExternalTaskSensor (#4536)
- [AIRFLOW-3522] Add support for sending Slack attachments (#4332)
-- [AIRFLOW-3569] Add "Trigger DAG" button in DAG page (/www only) (#4373)
-- [AIRFLOW-3569] Add "Trigger DAG" button in DAG page (/www_rbac only) (#4373)
+- [AIRFLOW-3569] Add "Trigger DAG" button in DAG page (#4373)
Review comment:
Yes. They all were. The script doesn't try to resolve the duplicate, it just fails if it finds one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org