You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/24 11:04:22 UTC

[GitHub] [flink] TisonKun commented on a change in pull request #9743: [hotfix][coordination] Wait for completion of MiniCluster#terminateExecutors

TisonKun commented on a change in pull request #9743: [hotfix][coordination] Wait for completion of MiniCluster#terminateExecutors
URL: https://github.com/apache/flink/pull/9743#discussion_r327552955
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
 ##########
 @@ -438,9 +438,8 @@ protected HighAvailabilityServices createHighAvailabilityServices(Configuration
 						rpcServicesTerminationFuture,
 						this::terminateMiniClusterServices);
 
-					final CompletableFuture<Void> executorsTerminationFuture = FutureUtils.runAfterwards(
-						remainingServicesTerminationFuture,
-						() -> terminateExecutors(shutdownTimeoutMillis));
+					final CompletableFuture<Void> executorsTerminationFuture = remainingServicesTerminationFuture
 
 Review comment:
   Right. Updating...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services