You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/04/18 02:08:34 UTC
Review Request: Fixed a bug in the status update manager to properly handle
duplicate ACK of an old update when waiting for the ACK of a new update.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10596/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Description
-------
See summary.
Diffs
-----
src/slave/slave.cpp 9ddfc521799173511c43ded4dbd7a6f4e2c3b82a
src/slave/status_update_manager.hpp a5d4f9e8c829e5ef63b16f8ab60efec1ebc1f73c
src/slave/status_update_manager.cpp f03885d4f7486286af3b61eaab957a1334280c78
src/tests/status_update_manager_tests.cpp e51d689a63342f4995dfc4b28ba8fe6505788646
src/tests/utils.hpp b5c577ddc3d4296fe8e77815cad158e2ef3bbbda
Diff: https://reviews.apache.org/r/10596/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Fixed a bug in the status update manager to properly
handle duplicate ACK of an old update when waiting for the ACK of a new
update.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 18, 2013, 12:58 a.m., Ben Mahler wrote:
> > src/slave/status_update_manager.hpp, line 108
> > <https://reviews.apache.org/r/10596/diff/2/?file=282124#file282124line108>
> >
> > I would prefer just simple sentences, rather than this @return format.
> >
> > Returns true if the acknowledgement was processed.
> > Returns false if the ack.. was ignored as a duplicate.
> > Returns an Error if the stream is in an error state, or the checkpointing failed?
> >
> > I based this on the gc.hpp header. If you want to stick with this format, you could match Jie's format in cgroups.hpp.
Used cgroups format, I think I like it better.
> On April 18, 2013, 12:58 a.m., Ben Mahler wrote:
> > src/slave/status_update_manager.hpp, line 229
> > <https://reviews.apache.org/r/10596/diff/2/?file=282124#file282124line229>
> >
> > Do you want to document this one?
No. Because, the doc is going to be same as what we have above in StatusUpdateManager.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10596/#review19366
-----------------------------------------------------------
On April 18, 2013, 12:44 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10596/
> -----------------------------------------------------------
>
> (Updated April 18, 2013, 12:44 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 826b6f4af0bb5dcc4bc0c69815d8570f477a5ad6
> src/slave/slave.cpp 9ddfc521799173511c43ded4dbd7a6f4e2c3b82a
> src/slave/status_update_manager.hpp a5d4f9e8c829e5ef63b16f8ab60efec1ebc1f73c
> src/slave/status_update_manager.cpp f03885d4f7486286af3b61eaab957a1334280c78
> src/tests/status_update_manager_tests.cpp e51d689a63342f4995dfc4b28ba8fe6505788646
> src/tests/utils.hpp b5c577ddc3d4296fe8e77815cad158e2ef3bbbda
>
> Diff: https://reviews.apache.org/r/10596/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed a bug in the status update manager to properly
handle duplicate ACK of an old update when waiting for the ACK of a new
update.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10596/#review19366
-----------------------------------------------------------
Ship it!
src/slave/slave.cpp
<https://reviews.apache.org/r/10596/#comment40071>
WARNING
src/slave/status_update_manager.hpp
<https://reviews.apache.org/r/10596/#comment40077>
I would prefer just simple sentences, rather than this @return format.
Returns true if the acknowledgement was processed.
Returns false if the ack.. was ignored as a duplicate.
Returns an Error if the stream is in an error state, or the checkpointing failed?
I based this on the gc.hpp header. If you want to stick with this format, you could match Jie's format in cgroups.hpp.
src/slave/status_update_manager.hpp
<https://reviews.apache.org/r/10596/#comment40078>
Do you want to document this one?
- Ben Mahler
On April 18, 2013, 12:44 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10596/
> -----------------------------------------------------------
>
> (Updated April 18, 2013, 12:44 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 826b6f4af0bb5dcc4bc0c69815d8570f477a5ad6
> src/slave/slave.cpp 9ddfc521799173511c43ded4dbd7a6f4e2c3b82a
> src/slave/status_update_manager.hpp a5d4f9e8c829e5ef63b16f8ab60efec1ebc1f73c
> src/slave/status_update_manager.cpp f03885d4f7486286af3b61eaab957a1334280c78
> src/tests/status_update_manager_tests.cpp e51d689a63342f4995dfc4b28ba8fe6505788646
> src/tests/utils.hpp b5c577ddc3d4296fe8e77815cad158e2ef3bbbda
>
> Diff: https://reviews.apache.org/r/10596/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed a bug in the status update manager to properly
handle duplicate ACK of an old update when waiting for the ACK of a new
update.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10596/
-----------------------------------------------------------
(Updated April 18, 2013, 1:23 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's. no need for review.
Description
-------
See summary.
Diffs (updated)
-----
src/slave/slave.hpp 826b6f4af0bb5dcc4bc0c69815d8570f477a5ad6
src/slave/slave.cpp 9ddfc521799173511c43ded4dbd7a6f4e2c3b82a
src/slave/status_update_manager.hpp a5d4f9e8c829e5ef63b16f8ab60efec1ebc1f73c
src/slave/status_update_manager.cpp f03885d4f7486286af3b61eaab957a1334280c78
src/tests/status_update_manager_tests.cpp e51d689a63342f4995dfc4b28ba8fe6505788646
src/tests/utils.hpp b5c577ddc3d4296fe8e77815cad158e2ef3bbbda
Diff: https://reviews.apache.org/r/10596/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Fixed a bug in the status update manager to properly
handle duplicate ACK of an old update when waiting for the ACK of a new
update.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10596/
-----------------------------------------------------------
(Updated April 18, 2013, 12:44 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's
Description
-------
See summary.
Diffs (updated)
-----
src/slave/slave.hpp 826b6f4af0bb5dcc4bc0c69815d8570f477a5ad6
src/slave/slave.cpp 9ddfc521799173511c43ded4dbd7a6f4e2c3b82a
src/slave/status_update_manager.hpp a5d4f9e8c829e5ef63b16f8ab60efec1ebc1f73c
src/slave/status_update_manager.cpp f03885d4f7486286af3b61eaab957a1334280c78
src/tests/status_update_manager_tests.cpp e51d689a63342f4995dfc4b28ba8fe6505788646
src/tests/utils.hpp b5c577ddc3d4296fe8e77815cad158e2ef3bbbda
Diff: https://reviews.apache.org/r/10596/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Fixed a bug in the status update manager to properly
handle duplicate ACK of an old update when waiting for the ACK of a new
update.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10596/#review19360
-----------------------------------------------------------
src/slave/status_update_manager.hpp
<https://reviews.apache.org/r/10596/#comment40061>
As discussed, make this return Try<bool>: Whether the ack was processed. That way we can log warnings for ignored updates rather than failures.
src/tests/status_update_manager_tests.cpp
<https://reviews.apache.org/r/10596/#comment40062>
I'd kill this, but up to you.
src/tests/status_update_manager_tests.cpp
<https://reviews.apache.org/r/10596/#comment40063>
indent
src/tests/status_update_manager_tests.cpp
<https://reviews.apache.org/r/10596/#comment40064>
Adjust the comment after you update to reflect it's no longer an "error".
- Ben Mahler
On April 18, 2013, 12:08 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10596/
> -----------------------------------------------------------
>
> (Updated April 18, 2013, 12:08 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 9ddfc521799173511c43ded4dbd7a6f4e2c3b82a
> src/slave/status_update_manager.hpp a5d4f9e8c829e5ef63b16f8ab60efec1ebc1f73c
> src/slave/status_update_manager.cpp f03885d4f7486286af3b61eaab957a1334280c78
> src/tests/status_update_manager_tests.cpp e51d689a63342f4995dfc4b28ba8fe6505788646
> src/tests/utils.hpp b5c577ddc3d4296fe8e77815cad158e2ef3bbbda
>
> Diff: https://reviews.apache.org/r/10596/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>