You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by mi...@apache.org on 2020/08/18 12:40:20 UTC

[httpcomponents-client] branch decimal-ids updated (a712463 -> ef0ba26)

This is an automated email from the ASF dual-hosted git repository.

michaelo pushed a change to branch decimal-ids
in repository https://gitbox.apache.org/repos/asf/httpcomponents-client.git.


 discard a712463  Use decimal numbers for endpoint/execution IDs
     new ef0ba26  Use decimal numbers for endpoint/execution IDs

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (a712463)
            \
             N -- N -- N   refs/heads/decimal-ids (ef0ba26)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../src/main/java/org/apache/hc/client5/http/impl/ExecSupport.java      | 2 +-
 .../hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java     | 2 +-
 .../hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)


[httpcomponents-client] 01/01: Use decimal numbers for endpoint/execution IDs

Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

michaelo pushed a commit to branch decimal-ids
in repository https://gitbox.apache.org/repos/asf/httpcomponents-client.git

commit ef0ba264ff80444690f6674601893564b9460749
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Tue Aug 18 12:16:46 2020 +0200

    Use decimal numbers for endpoint/execution IDs
    
    This closes #249
---
 .../src/main/java/org/apache/hc/client5/http/impl/ExecSupport.java      | 2 +-
 .../hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java     | 2 +-
 .../hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/ExecSupport.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/ExecSupport.java
index c9e42ba..4d7c5f6 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/ExecSupport.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/ExecSupport.java
@@ -45,7 +45,7 @@ public final class ExecSupport {
     }
 
     public static String getNextExchangeId() {
-        return String.format("ex-%08X", COUNT.incrementAndGet());
+        return String.format("ex-%010d", COUNT.incrementAndGet());
     }
 
 }
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java
index e236ee4..3105719 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java
@@ -527,7 +527,7 @@ public class PoolingHttpClientConnectionManager
         InternalConnectionEndpoint(
                 final PoolEntry<HttpRoute, ManagedHttpClientConnection> poolEntry) {
             this.poolEntryRef = new AtomicReference<>(poolEntry);
-            this.id = String.format("ep-%08X", COUNT.getAndIncrement());
+            this.id = String.format("ep-%010d", COUNT.getAndIncrement());
         }
 
         @Override
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
index 974df99..ed51647 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
@@ -492,7 +492,7 @@ public class PoolingAsyncClientConnectionManager implements AsyncClientConnectio
 
         InternalConnectionEndpoint(final PoolEntry<HttpRoute, ManagedAsyncClientConnection> poolEntry) {
             this.poolEntryRef = new AtomicReference<>(poolEntry);
-            this.id = String.format("ep-%08X", COUNT.getAndIncrement());
+            this.id = String.format("ep-%010d", COUNT.getAndIncrement());
         }
 
         @Override