You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/10/10 08:08:49 UTC

[GitHub] [hadoop] dannycjones commented on a diff in pull request #4965: HADOOP-18156. Address JavaDoc warnings in classes like MarkerTool, S3ObjectAttributes, etc

dannycjones commented on code in PR #4965:
URL: https://github.com/apache/hadoop/pull/4965#discussion_r991011698


##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/tools/MarkerTool.java:
##########
@@ -960,43 +960,64 @@ public static final class ScanArgsBuilder {
     /** Consider only markers in nonauth paths as errors. */
     private boolean nonAuth = false;
 
-    /** Source FS; must be or wrap an S3A FS. */
+    /** Source FS; must be or wrap an S3A FS.

Review Comment:
   Do you think it's a good idea adding this to CheckStyle?
   
   This one looks relevant (though maybe it will flag a lot of existing files): https://checkstyle.sourceforge.io/config_javadoc.html#JavadocContentLocation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org