[GitHub] [incubator-superset] villebro commented on a change in pull request #10836: feat: Stop pending queries when user close dashboard

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #10836:
URL: https://github.com/apache/incubator-superset/pull/10836#discussion_r499838550



##########
File path: superset/charts/api.py
##########
@@ -503,6 +504,50 @@ def data(self) -> Response:
 
         return response
 
+    @expose("/data/stop", methods=["POST"])

Review comment:
       While the `dashboard` namespace was considered, the main use case for this endpoint is to terminate pending chart data queries, hence the `chart` namespace. The signature will likely be broadened in the future, making it possible to cancel queries based on other parameters (`cache_key`, `slice_id` etc). This endpoint will likely change significantly when the async framework is fully implemented, and will be revisited then.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org