You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/02/27 14:10:13 UTC

DO NOT REPLY [Bug 48827] New: Error validating empty tag that contains jsp:attribute in JSP documents in XML syntax

https://issues.apache.org/bugzilla/show_bug.cgi?id=48827

           Summary: Error validating empty tag that contains jsp:attribute
                    in JSP documents in XML syntax
           Product: Tomcat 6
           Version: 6.0.24
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: regression
          Priority: P2
         Component: Jasper
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: knst.kolinko@gmail.com


Created an attachment (id=25065)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25065)
emptyTagWithAttribute_Xml.jspx

Steps to reproduce:
1. Place the attached emptyTagWithAttribute_Xml.jspx into webapps/examples
2. Open http://localhost:8080/examples/emptyTagWithAttribute_Xml.jspx
3. Observe error 500:

org.apache.jasper.JasperException: /emptyTagWithAttribute_Xml.jspx(6,18)
According to TLD, tag my:shuffle must be empty, but is not
   
org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:40)
   
org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.java:407)
   
org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.java:88)
   
org.apache.jasper.compiler.JspDocumentParser.parse(JspDocumentParser.java:216)
   
org.apache.jasper.compiler.ParserController.doParse(ParserController.java:239)
   
org.apache.jasper.compiler.ParserController.parse(ParserController.java:103)
    org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:170)
    org.apache.jasper.compiler.Compiler.compile(Compiler.java:332)
    org.apache.jasper.compiler.Compiler.compile(Compiler.java:312)
    org.apache.jasper.compiler.Compiler.compile(Compiler.java:299)
   
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:589)
   
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:317)
    org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:313)
    org.apache.jasper.servlet.JspServlet.service(JspServlet.java:260)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:717)


The above stack trace is with 6.0.25 release candidate. IIRC, I observed the
same with 6.0.24 recently. It works correctly with TC 6.0.20.

This issue affects JSP Documents (XML syntax) only. The pages in plain JSP
syntax (e.g. shuffle.jsp in our examples) work correctly.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48827] Error validating empty tag that contains jsp:attribute in JSP documents in XML syntax

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48827

--- Comment #3 from Mark Thomas <ma...@apache.org> 2010-03-03 21:05:22 UTC ---
Fixed in trunk (with a couple of test cases) and proposed for 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48827] Error validating empty tag that contains jsp:attribute in JSP documents in XML syntax

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48827

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48827] Error validating empty tag that contains jsp:attribute in JSP documents in XML syntax

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48827

--- Comment #1 from Konstantin Kolinko <kn...@gmail.com> 2010-02-27 13:11:12 UTC ---
Created an attachment (id=25066)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25066)
emptyTagWithAttribute_Jsp.jsp

The same page in plain JSP syntax. It works.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48827] Error validating empty tag that contains jsp:attribute in JSP documents in XML syntax

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48827

--- Comment #2 from Mark Thomas <ma...@apache.org> 2010-03-03 20:25:55 UTC ---
It is a regression in the fix for bug47977. Looking at a fix now...

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48827] Error validating empty tag that contains jsp:attribute in JSP documents in XML syntax

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48827

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Mark Thomas <ma...@apache.org> 2010-09-27 19:01:17 EDT ---
I have review the EBNF in the JSP 2.2 spec and I can't see anything that would
permit comments in a tag that should have an empty body.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: DO NOT REPLY [Bug 48827] Error validating empty tag that contains jsp:attribute in JSP documents in XML syntax

Posted by Ian Darwin <ia...@darwinsys.com>.
> One more regression due to bug47977 fix:
> If the empty tag contains a comment, Tomcat barks that "tag .. must be empty
> but is not".

I have never heard a cat bark. Not even a Tomcat.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48827] Error validating empty tag that contains jsp:attribute in JSP documents in XML syntax

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48827

--- Comment #5 from Konstantin Kolinko <kn...@gmail.com> 2010-07-09 07:52:16 EDT ---
Created an attachment (id=25736)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25736)
emptyTagWithSpaceAndComment_Xml.jspx

One more regression due to bug47977 fix:
If the empty tag contains a comment, Tomcat barks that "tag .. must be empty
but is not".

I am attaching a JSPX document that reproduces this issue. The steps to
reproduce are the same as in Description of this issue.

Reproducible in 6.0.28 and in the current trunk (thus released 7.0.0-beta is
also affected).

I tested 5.5.30 as well and it works correctly.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48827] Error validating empty tag that contains jsp:attribute in JSP documents in XML syntax

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48827

Konstantin Kolinko <kn...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Konstantin Kolinko <kn...@gmail.com> 2010-03-05 18:38:41 UTC ---
Fixed in 6.0 in r919354 and will be in 6.0.26 onwards.

I tested the current 5.5 (that will be 5.5.29) and it is not affected by this
issue.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org