You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by sh...@apache.org on 2016/11/15 02:08:39 UTC
ignite git commit: IGNITE-3066: Review, 3rd round.
Repository: ignite
Updated Branches:
refs/heads/ignite-2788 606ff932c -> 8aa28e26a
IGNITE-3066: Review, 3rd round.
Project: http://git-wip-us.apache.org/repos/asf/ignite/repo
Commit: http://git-wip-us.apache.org/repos/asf/ignite/commit/8aa28e26
Tree: http://git-wip-us.apache.org/repos/asf/ignite/tree/8aa28e26
Diff: http://git-wip-us.apache.org/repos/asf/ignite/diff/8aa28e26
Branch: refs/heads/ignite-2788
Commit: 8aa28e26a3c17012fc6d95b16208ff0b5a115fc5
Parents: 606ff93
Author: shtykh_roman <rs...@yahoo.com>
Authored: Tue Nov 15 11:08:06 2016 +0900
Committer: shtykh_roman <rs...@yahoo.com>
Committed: Tue Nov 15 11:08:06 2016 +0900
----------------------------------------------------------------------
.../org/apache/ignite/internal/IgnitionEx.java | 8 --
.../GridRedisConnectionCommandHandler.java | 2 +-
.../redis/GridRedisRestCommandHandler.java | 97 ++++++++++++++++++++
.../redis/GridRedisThruRestCommandHandler.java | 97 --------------------
.../redis/key/GridRedisDelCommandHandler.java | 12 +--
.../key/GridRedisExistsCommandHandler.java | 12 +--
.../server/GridRedisDbSizeCommandHandler.java | 4 +-
.../string/GridRedisAppendCommandHandler.java | 4 +-
.../string/GridRedisGetCommandHandler.java | 4 +-
.../string/GridRedisGetRangeCommandHandler.java | 4 +-
.../string/GridRedisGetSetCommandHandler.java | 4 +-
.../string/GridRedisIncrDecrCommandHandler.java | 4 +-
.../string/GridRedisMGetCommandHandler.java | 10 +-
.../string/GridRedisMSetCommandHandler.java | 6 +-
.../string/GridRedisSetCommandHandler.java | 18 ++--
.../string/GridRedisSetRangeCommandHandler.java | 4 +-
.../string/GridRedisStrlenCommandHandler.java | 4 +-
.../protocols/tcp/redis/GridRedisCommand.java | 1 +
.../protocols/tcp/redis/GridRedisMessage.java | 2 +-
.../tcp/redis/GridRedisProtocolParser.java | 2 +-
20 files changed, 143 insertions(+), 156 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/IgnitionEx.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/IgnitionEx.java b/modules/core/src/main/java/org/apache/ignite/internal/IgnitionEx.java
index 50f64c6..aad96fb 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/IgnitionEx.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/IgnitionEx.java
@@ -1474,9 +1474,6 @@ public class IgnitionEx {
/** REST requests executor service. */
private ExecutorService restExecSvc;
- /** Redis requests executor service. */
- private ExecutorService redisExecSvc;
-
/** Utility cache executor service. */
private ExecutorService utilityCacheExecSvc;
@@ -2364,11 +2361,6 @@ public class IgnitionEx {
restExecSvc = null;
- if (redisExecSvc != null)
- U.shutdownNow(getClass(), redisExecSvc, log);
-
- redisExecSvc = null;
-
U.shutdownNow(getClass(), utilityCacheExecSvc, log);
utilityCacheExecSvc = null;
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/GridRedisConnectionCommandHandler.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/GridRedisConnectionCommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/GridRedisConnectionCommandHandler.java
index a5993c1..b8a042d 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/GridRedisConnectionCommandHandler.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/GridRedisConnectionCommandHandler.java
@@ -58,7 +58,7 @@ public class GridRedisConnectionCommandHandler implements GridRedisCommandHandle
return new GridFinishedFuture<>(msg);
case QUIT:
- msg.setResponse(GridRedisProtocolParser.OkString());
+ msg.setResponse(GridRedisProtocolParser.oKString());
return new GridFinishedFuture<>(msg);
case ECHO:
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/GridRedisRestCommandHandler.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/GridRedisRestCommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/GridRedisRestCommandHandler.java
new file mode 100644
index 0000000..461cf13
--- /dev/null
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/GridRedisRestCommandHandler.java
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.rest.handlers.redis;
+
+import java.nio.ByteBuffer;
+import java.util.List;
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.internal.IgniteInternalFuture;
+import org.apache.ignite.internal.processors.rest.GridRestProtocolHandler;
+import org.apache.ignite.internal.processors.rest.GridRestResponse;
+import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisMessage;
+import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisProtocolParser;
+import org.apache.ignite.internal.processors.rest.handlers.redis.exception.GridRedisTypeException;
+import org.apache.ignite.internal.processors.rest.request.GridRestRequest;
+import org.apache.ignite.internal.util.future.GridFinishedFuture;
+import org.apache.ignite.internal.util.typedef.CX1;
+
+/**
+ * Redis command handler done via REST.
+ */
+public abstract class GridRedisRestCommandHandler implements GridRedisCommandHandler {
+ /** REST protocol handler. */
+ protected final GridRestProtocolHandler hnd;
+
+ /**
+ * Constructor.
+ *
+ * @param hnd REST protocol handler.
+ */
+ public GridRedisRestCommandHandler(final GridRestProtocolHandler hnd) {
+ this.hnd = hnd;
+ }
+
+ /** {@inheritDoc} */
+ @Override public IgniteInternalFuture<GridRedisMessage> handleAsync(final GridRedisMessage msg) {
+ assert msg != null;
+
+ try {
+ return hnd.handleAsync(asRestRequest(msg))
+ .chain(new CX1<IgniteInternalFuture<GridRestResponse>, GridRedisMessage>() {
+ @Override
+ public GridRedisMessage applyx(IgniteInternalFuture<GridRestResponse> f)
+ throws IgniteCheckedException {
+ GridRestResponse restRes = f.get();
+
+ if (restRes.getSuccessStatus() == GridRestResponse.STATUS_SUCCESS)
+ msg.setResponse(makeResponse(restRes, msg.auxMKeys()));
+ else
+ msg.setResponse(GridRedisProtocolParser.toGenericError("Operation error!"));
+
+ return msg;
+ }
+ });
+ }
+ catch (IgniteCheckedException e) {
+ if (e instanceof GridRedisTypeException)
+ msg.setResponse(GridRedisProtocolParser.toTypeError(e.getMessage()));
+ else
+ msg.setResponse(GridRedisProtocolParser.toGenericError(e.getMessage()));
+
+ return new GridFinishedFuture<>(msg);
+ }
+ }
+
+ /**
+ * Converts {@link GridRedisMessage} to {@link GridRestRequest}.
+ *
+ * @param msg {@link GridRedisMessage}
+ * @return {@link GridRestRequest}
+ * @throws IgniteCheckedException If fails.
+ */
+ public abstract GridRestRequest asRestRequest(GridRedisMessage msg) throws IgniteCheckedException;
+
+ /**
+ * Prepares a response according to the request.
+ *
+ * @param resp REST response.
+ * @param params Auxiliary parameters.
+ * @return Response for the command.
+ */
+ public abstract ByteBuffer makeResponse(GridRestResponse resp, List<String> params);
+}
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/GridRedisThruRestCommandHandler.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/GridRedisThruRestCommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/GridRedisThruRestCommandHandler.java
deleted file mode 100644
index 6248520..0000000
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/GridRedisThruRestCommandHandler.java
+++ /dev/null
@@ -1,97 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.ignite.internal.processors.rest.handlers.redis;
-
-import java.nio.ByteBuffer;
-import java.util.List;
-import org.apache.ignite.IgniteCheckedException;
-import org.apache.ignite.internal.IgniteInternalFuture;
-import org.apache.ignite.internal.processors.rest.GridRestProtocolHandler;
-import org.apache.ignite.internal.processors.rest.GridRestResponse;
-import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisMessage;
-import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisProtocolParser;
-import org.apache.ignite.internal.processors.rest.handlers.redis.exception.GridRedisTypeException;
-import org.apache.ignite.internal.processors.rest.request.GridRestRequest;
-import org.apache.ignite.internal.util.future.GridFinishedFuture;
-import org.apache.ignite.internal.util.typedef.CX1;
-
-/**
- * Redis command handler done via REST.
- */
-public abstract class GridRedisThruRestCommandHandler implements GridRedisCommandHandler {
- /** REST protocol handler. */
- protected final GridRestProtocolHandler hnd;
-
- /**
- * Constructor.
- *
- * @param hnd REST protocol handler.
- */
- public GridRedisThruRestCommandHandler(final GridRestProtocolHandler hnd) {
- this.hnd = hnd;
- }
-
- /** {@inheritDoc} */
- @Override public IgniteInternalFuture<GridRedisMessage> handleAsync(final GridRedisMessage msg) {
- assert msg != null;
-
- try {
- return hnd.handleAsync(asRestRequest(msg))
- .chain(new CX1<IgniteInternalFuture<GridRestResponse>, GridRedisMessage>() {
- @Override
- public GridRedisMessage applyx(IgniteInternalFuture<GridRestResponse> f)
- throws IgniteCheckedException {
- GridRestResponse restRes = f.get();
-
- if (restRes.getSuccessStatus() == GridRestResponse.STATUS_SUCCESS)
- msg.setResponse(makeResponse(restRes, msg.auxMKeys()));
- else
- msg.setResponse(GridRedisProtocolParser.toGenericError("Operation error!"));
-
- return msg;
- }
- });
- }
- catch (IgniteCheckedException e) {
- if (e instanceof GridRedisTypeException)
- msg.setResponse(GridRedisProtocolParser.toTypeError(e.getMessage()));
- else
- msg.setResponse(GridRedisProtocolParser.toGenericError(e.getMessage()));
-
- return new GridFinishedFuture<>(msg);
- }
- }
-
- /**
- * Converts {@link GridRedisMessage} to {@link GridRestRequest}.
- *
- * @param msg {@link GridRedisMessage}
- * @return {@link GridRestRequest}
- * @throws IgniteCheckedException If fails.
- */
- public abstract GridRestRequest asRestRequest(GridRedisMessage msg) throws IgniteCheckedException;
-
- /**
- * Prepares a response according to the request.
- *
- * @param resp REST response.
- * @param params Auxiliary parameters.
- * @return Response for the command.
- */
- public abstract ByteBuffer makeResponse(GridRestResponse resp, List<String> params);
-}
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/key/GridRedisDelCommandHandler.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/key/GridRedisDelCommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/key/GridRedisDelCommandHandler.java
index a444d91..d77e02c 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/key/GridRedisDelCommandHandler.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/key/GridRedisDelCommandHandler.java
@@ -19,17 +19,16 @@ package org.apache.ignite.internal.processors.rest.handlers.redis.key;
import java.nio.ByteBuffer;
import java.util.Collection;
-import java.util.Iterator;
import java.util.List;
import java.util.Map;
import org.apache.ignite.IgniteCheckedException;
import org.apache.ignite.internal.processors.rest.GridRestProtocolHandler;
import org.apache.ignite.internal.processors.rest.GridRestResponse;
+import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisRestCommandHandler;
+import org.apache.ignite.internal.processors.rest.handlers.redis.exception.GridRedisGenericException;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisCommand;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisMessage;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisProtocolParser;
-import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisThruRestCommandHandler;
-import org.apache.ignite.internal.processors.rest.handlers.redis.exception.GridRedisGenericException;
import org.apache.ignite.internal.processors.rest.request.GridRestCacheRequest;
import org.apache.ignite.internal.processors.rest.request.GridRestRequest;
import org.apache.ignite.internal.util.typedef.internal.U;
@@ -40,7 +39,7 @@ import static org.apache.ignite.internal.processors.rest.protocols.tcp.redis.Gri
/**
* Redis DEL command handler.
*/
-public class GridRedisDelCommandHandler extends GridRedisThruRestCommandHandler {
+public class GridRedisDelCommandHandler extends GridRedisRestCommandHandler {
/** Supported commands. */
private static final Collection<GridRedisCommand> SUPPORTED_COMMANDS = U.sealList(
DEL
@@ -71,10 +70,9 @@ public class GridRedisDelCommandHandler extends GridRedisThruRestCommandHandler
List<String> keys = msg.auxMKeys();
Map<Object, Object> mget = U.newHashMap(keys.size());
- Iterator<String> mgetIt = keys.iterator();
- while (mgetIt.hasNext())
- mget.put(mgetIt.next(), null);
+ for (String key : keys)
+ mget.put(key, null);
restReq.values(mget);
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/key/GridRedisExistsCommandHandler.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/key/GridRedisExistsCommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/key/GridRedisExistsCommandHandler.java
index 3649580..bea872c 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/key/GridRedisExistsCommandHandler.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/key/GridRedisExistsCommandHandler.java
@@ -19,17 +19,16 @@ package org.apache.ignite.internal.processors.rest.handlers.redis.key;
import java.nio.ByteBuffer;
import java.util.Collection;
-import java.util.Iterator;
import java.util.List;
import java.util.Map;
import org.apache.ignite.IgniteCheckedException;
import org.apache.ignite.internal.processors.rest.GridRestProtocolHandler;
import org.apache.ignite.internal.processors.rest.GridRestResponse;
+import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisRestCommandHandler;
+import org.apache.ignite.internal.processors.rest.handlers.redis.exception.GridRedisGenericException;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisCommand;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisMessage;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisProtocolParser;
-import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisThruRestCommandHandler;
-import org.apache.ignite.internal.processors.rest.handlers.redis.exception.GridRedisGenericException;
import org.apache.ignite.internal.processors.rest.request.GridRestCacheRequest;
import org.apache.ignite.internal.processors.rest.request.GridRestRequest;
import org.apache.ignite.internal.util.typedef.internal.U;
@@ -40,7 +39,7 @@ import static org.apache.ignite.internal.processors.rest.protocols.tcp.redis.Gri
/**
* Redis EXISTS command handler.
*/
-public class GridRedisExistsCommandHandler extends GridRedisThruRestCommandHandler {
+public class GridRedisExistsCommandHandler extends GridRedisRestCommandHandler {
/** Supported commands. */
private static final Collection<GridRedisCommand> SUPPORTED_COMMANDS = U.sealList(
EXISTS
@@ -71,10 +70,9 @@ public class GridRedisExistsCommandHandler extends GridRedisThruRestCommandHandl
List<String> keys = msg.auxMKeys();
Map<Object, Object> mget = U.newHashMap(keys.size());
- Iterator<String> mgetIt = keys.iterator();
- while (mgetIt.hasNext())
- mget.put(mgetIt.next(), null);
+ for (String key : keys)
+ mget.put(key, null);
restReq.values(mget);
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/server/GridRedisDbSizeCommandHandler.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/server/GridRedisDbSizeCommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/server/GridRedisDbSizeCommandHandler.java
index bde9a81..ce912df 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/server/GridRedisDbSizeCommandHandler.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/server/GridRedisDbSizeCommandHandler.java
@@ -26,7 +26,7 @@ import org.apache.ignite.internal.processors.rest.GridRestResponse;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisCommand;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisMessage;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisProtocolParser;
-import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisThruRestCommandHandler;
+import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisRestCommandHandler;
import org.apache.ignite.internal.processors.rest.request.GridRestCacheRequest;
import org.apache.ignite.internal.processors.rest.request.GridRestRequest;
import org.apache.ignite.internal.util.typedef.internal.U;
@@ -37,7 +37,7 @@ import static org.apache.ignite.internal.processors.rest.protocols.tcp.redis.Gri
/**
* Redis DBSIZE command handler.
*/
-public class GridRedisDbSizeCommandHandler extends GridRedisThruRestCommandHandler {
+public class GridRedisDbSizeCommandHandler extends GridRedisRestCommandHandler {
/** Supported commands. */
private static final Collection<GridRedisCommand> SUPPORTED_COMMANDS = U.sealList(
DBSIZE
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisAppendCommandHandler.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisAppendCommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisAppendCommandHandler.java
index fa70793..39a0ba2 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisAppendCommandHandler.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisAppendCommandHandler.java
@@ -23,7 +23,7 @@ import java.util.List;
import org.apache.ignite.IgniteCheckedException;
import org.apache.ignite.internal.processors.rest.GridRestProtocolHandler;
import org.apache.ignite.internal.processors.rest.GridRestResponse;
-import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisThruRestCommandHandler;
+import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisRestCommandHandler;
import org.apache.ignite.internal.processors.rest.handlers.redis.exception.GridRedisGenericException;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisCommand;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisMessage;
@@ -40,7 +40,7 @@ import static org.apache.ignite.internal.processors.rest.protocols.tcp.redis.Gri
/**
* Redis APPEND command handler.
*/
-public class GridRedisAppendCommandHandler extends GridRedisThruRestCommandHandler {
+public class GridRedisAppendCommandHandler extends GridRedisRestCommandHandler {
/** Supported commands. */
private static final Collection<GridRedisCommand> SUPPORTED_COMMANDS = U.sealList(
APPEND
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisGetCommandHandler.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisGetCommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisGetCommandHandler.java
index 1a75a76..cc41dac 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisGetCommandHandler.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisGetCommandHandler.java
@@ -26,7 +26,7 @@ import org.apache.ignite.internal.processors.rest.GridRestResponse;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisCommand;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisMessage;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisProtocolParser;
-import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisThruRestCommandHandler;
+import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisRestCommandHandler;
import org.apache.ignite.internal.processors.rest.request.GridRestCacheRequest;
import org.apache.ignite.internal.processors.rest.request.GridRestRequest;
import org.apache.ignite.internal.util.typedef.internal.U;
@@ -37,7 +37,7 @@ import static org.apache.ignite.internal.processors.rest.protocols.tcp.redis.Gri
/**
* Redis GET command handler.
*/
-public class GridRedisGetCommandHandler extends GridRedisThruRestCommandHandler {
+public class GridRedisGetCommandHandler extends GridRedisRestCommandHandler {
/** Supported commands. */
private static final Collection<GridRedisCommand> SUPPORTED_COMMANDS = U.sealList(
GET
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisGetRangeCommandHandler.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisGetRangeCommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisGetRangeCommandHandler.java
index 8850ecf..fe0caf7 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisGetRangeCommandHandler.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisGetRangeCommandHandler.java
@@ -23,7 +23,7 @@ import java.util.List;
import org.apache.ignite.IgniteCheckedException;
import org.apache.ignite.internal.processors.rest.GridRestProtocolHandler;
import org.apache.ignite.internal.processors.rest.GridRestResponse;
-import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisThruRestCommandHandler;
+import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisRestCommandHandler;
import org.apache.ignite.internal.processors.rest.handlers.redis.exception.GridRedisGenericException;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisCommand;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisMessage;
@@ -38,7 +38,7 @@ import static org.apache.ignite.internal.processors.rest.protocols.tcp.redis.Gri
/**
* Redis SETRANGE command handler.
*/
-public class GridRedisGetRangeCommandHandler extends GridRedisThruRestCommandHandler {
+public class GridRedisGetRangeCommandHandler extends GridRedisRestCommandHandler {
/** Supported commands. */
private static final Collection<GridRedisCommand> SUPPORTED_COMMANDS = U.sealList(
GETRANGE
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisGetSetCommandHandler.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisGetSetCommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisGetSetCommandHandler.java
index 80d678e..70b72cd 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisGetSetCommandHandler.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisGetSetCommandHandler.java
@@ -26,7 +26,7 @@ import org.apache.ignite.internal.processors.rest.GridRestResponse;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisCommand;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisMessage;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisProtocolParser;
-import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisThruRestCommandHandler;
+import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisRestCommandHandler;
import org.apache.ignite.internal.processors.rest.handlers.redis.exception.GridRedisGenericException;
import org.apache.ignite.internal.processors.rest.request.GridRestCacheRequest;
import org.apache.ignite.internal.processors.rest.request.GridRestRequest;
@@ -38,7 +38,7 @@ import static org.apache.ignite.internal.processors.rest.protocols.tcp.redis.Gri
/**
* Redis GETSET command handler.
*/
-public class GridRedisGetSetCommandHandler extends GridRedisThruRestCommandHandler {
+public class GridRedisGetSetCommandHandler extends GridRedisRestCommandHandler {
/** Supported commands. */
private static final Collection<GridRedisCommand> SUPPORTED_COMMANDS = U.sealList(
GETSET
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisIncrDecrCommandHandler.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisIncrDecrCommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisIncrDecrCommandHandler.java
index f713562..ee183ec 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisIncrDecrCommandHandler.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisIncrDecrCommandHandler.java
@@ -24,7 +24,7 @@ import java.util.List;
import org.apache.ignite.IgniteCheckedException;
import org.apache.ignite.internal.processors.rest.GridRestProtocolHandler;
import org.apache.ignite.internal.processors.rest.GridRestResponse;
-import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisThruRestCommandHandler;
+import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisRestCommandHandler;
import org.apache.ignite.internal.processors.rest.handlers.redis.exception.GridRedisGenericException;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisCommand;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisMessage;
@@ -45,7 +45,7 @@ import static org.apache.ignite.internal.processors.rest.protocols.tcp.redis.Gri
/**
* Redis INCR/DECR command handler.
*/
-public class GridRedisIncrDecrCommandHandler extends GridRedisThruRestCommandHandler {
+public class GridRedisIncrDecrCommandHandler extends GridRedisRestCommandHandler {
/** Supported commands. */
private static final Collection<GridRedisCommand> SUPPORTED_COMMANDS = U.sealList(
INCR,
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisMGetCommandHandler.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisMGetCommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisMGetCommandHandler.java
index 5c46e86..876c88d 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisMGetCommandHandler.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisMGetCommandHandler.java
@@ -19,7 +19,6 @@ package org.apache.ignite.internal.processors.rest.handlers.redis.string;
import java.nio.ByteBuffer;
import java.util.Collection;
-import java.util.Iterator;
import java.util.List;
import java.util.Map;
import org.apache.ignite.IgniteCheckedException;
@@ -28,7 +27,7 @@ import org.apache.ignite.internal.processors.rest.GridRestResponse;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisCommand;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisMessage;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisProtocolParser;
-import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisThruRestCommandHandler;
+import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisRestCommandHandler;
import org.apache.ignite.internal.processors.rest.handlers.redis.exception.GridRedisGenericException;
import org.apache.ignite.internal.processors.rest.request.GridRestCacheRequest;
import org.apache.ignite.internal.processors.rest.request.GridRestRequest;
@@ -40,7 +39,7 @@ import static org.apache.ignite.internal.processors.rest.protocols.tcp.redis.Gri
/**
* Redis MGET command handler.
*/
-public class GridRedisMGetCommandHandler extends GridRedisThruRestCommandHandler {
+public class GridRedisMGetCommandHandler extends GridRedisRestCommandHandler {
/** Supported commands. */
private static final Collection<GridRedisCommand> SUPPORTED_COMMANDS = U.sealList(
MGET
@@ -71,10 +70,9 @@ public class GridRedisMGetCommandHandler extends GridRedisThruRestCommandHandler
List<String> keys = msg.auxMKeys();
Map<Object, Object> mget = U.newHashMap(keys.size());
- Iterator<String> mgetIt = keys.iterator();
- while (mgetIt.hasNext())
- mget.put(mgetIt.next(), null);
+ for (String key : keys)
+ mget.put(key, null);
restReq.values(mget);
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisMSetCommandHandler.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisMSetCommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisMSetCommandHandler.java
index 7f5449a..a385d9c 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisMSetCommandHandler.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisMSetCommandHandler.java
@@ -28,7 +28,7 @@ import org.apache.ignite.internal.processors.rest.GridRestResponse;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisCommand;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisMessage;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisProtocolParser;
-import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisThruRestCommandHandler;
+import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisRestCommandHandler;
import org.apache.ignite.internal.processors.rest.request.GridRestCacheRequest;
import org.apache.ignite.internal.processors.rest.request.GridRestRequest;
import org.apache.ignite.internal.util.typedef.internal.U;
@@ -39,7 +39,7 @@ import static org.apache.ignite.internal.processors.rest.protocols.tcp.redis.Gri
/**
* Redis MSET command handler.
*/
-public class GridRedisMSetCommandHandler extends GridRedisThruRestCommandHandler {
+public class GridRedisMSetCommandHandler extends GridRedisRestCommandHandler {
/** Supported commands. */
private static final Collection<GridRedisCommand> SUPPORTED_COMMANDS = U.sealList(
MSET
@@ -80,6 +80,6 @@ public class GridRedisMSetCommandHandler extends GridRedisThruRestCommandHandler
/** {@inheritDoc} */
@Override public ByteBuffer makeResponse(final GridRestResponse restRes, List<String> params) {
- return GridRedisProtocolParser.OkString();
+ return GridRedisProtocolParser.oKString();
}
}
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisSetCommandHandler.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisSetCommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisSetCommandHandler.java
index bbc3c06..1e9526d 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisSetCommandHandler.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisSetCommandHandler.java
@@ -23,7 +23,7 @@ import java.util.List;
import org.apache.ignite.IgniteCheckedException;
import org.apache.ignite.internal.processors.rest.GridRestProtocolHandler;
import org.apache.ignite.internal.processors.rest.GridRestResponse;
-import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisThruRestCommandHandler;
+import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisRestCommandHandler;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisCommand;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisMessage;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisProtocolParser;
@@ -41,7 +41,7 @@ import static org.apache.ignite.internal.processors.rest.protocols.tcp.redis.Gri
* <p>
* No key expiration is currently supported.
*/
-public class GridRedisSetCommandHandler extends GridRedisThruRestCommandHandler {
+public class GridRedisSetCommandHandler extends GridRedisRestCommandHandler {
/** Supported commands. */
private static final Collection<GridRedisCommand> SUPPORTED_COMMANDS = U.sealList(
SET
@@ -100,9 +100,9 @@ public class GridRedisSetCommandHandler extends GridRedisThruRestCommandHandler
*/
private boolean isNx(List<String> params) {
if (params.size() >= 3)
- return params.get(0).equalsIgnoreCase("nx") || params.get(2).equalsIgnoreCase("nx");
- else
- return params.get(0).equalsIgnoreCase("nx");
+ return "nx".equalsIgnoreCase(params.get(0)) || "nx".equalsIgnoreCase(params.get(2));
+
+ return "nx".equalsIgnoreCase(params.get(0));
}
/**
@@ -111,9 +111,9 @@ public class GridRedisSetCommandHandler extends GridRedisThruRestCommandHandler
*/
private boolean isXx(List<String> params) {
if (params.size() >= 3)
- return params.get(0).equalsIgnoreCase("xx") || params.get(2).equalsIgnoreCase("xx");
- else
- return params.get(0).equalsIgnoreCase("xx");
+ return "xx".equalsIgnoreCase(params.get(0)) || "xx".equalsIgnoreCase(params.get(2));
+
+ return "xx".equalsIgnoreCase(params.get(0));
}
/** {@inheritDoc} */
@@ -123,6 +123,6 @@ public class GridRedisSetCommandHandler extends GridRedisThruRestCommandHandler
if (resp == null)
return GridRedisProtocolParser.nil();
- return (!(boolean)resp ? GridRedisProtocolParser.nil() : GridRedisProtocolParser.OkString());
+ return (!(boolean)resp ? GridRedisProtocolParser.nil() : GridRedisProtocolParser.oKString());
}
}
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisSetRangeCommandHandler.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisSetRangeCommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisSetRangeCommandHandler.java
index 901f510..52536c8 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisSetRangeCommandHandler.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisSetRangeCommandHandler.java
@@ -23,7 +23,7 @@ import java.util.List;
import org.apache.ignite.IgniteCheckedException;
import org.apache.ignite.internal.processors.rest.GridRestProtocolHandler;
import org.apache.ignite.internal.processors.rest.GridRestResponse;
-import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisThruRestCommandHandler;
+import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisRestCommandHandler;
import org.apache.ignite.internal.processors.rest.handlers.redis.exception.GridRedisGenericException;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisCommand;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisMessage;
@@ -39,7 +39,7 @@ import static org.apache.ignite.internal.processors.rest.protocols.tcp.redis.Gri
/**
* Redis SETRANGE command handler.
*/
-public class GridRedisSetRangeCommandHandler extends GridRedisThruRestCommandHandler {
+public class GridRedisSetRangeCommandHandler extends GridRedisRestCommandHandler {
/** Supported commands. */
private static final Collection<GridRedisCommand> SUPPORTED_COMMANDS = U.sealList(
SETRANGE
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisStrlenCommandHandler.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisStrlenCommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisStrlenCommandHandler.java
index 23ee02f..ada2b25 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisStrlenCommandHandler.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/redis/string/GridRedisStrlenCommandHandler.java
@@ -26,7 +26,7 @@ import org.apache.ignite.internal.processors.rest.GridRestResponse;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisCommand;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisMessage;
import org.apache.ignite.internal.processors.rest.protocols.tcp.redis.GridRedisProtocolParser;
-import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisThruRestCommandHandler;
+import org.apache.ignite.internal.processors.rest.handlers.redis.GridRedisRestCommandHandler;
import org.apache.ignite.internal.processors.rest.request.GridRestCacheRequest;
import org.apache.ignite.internal.processors.rest.request.GridRestRequest;
import org.apache.ignite.internal.util.typedef.internal.U;
@@ -37,7 +37,7 @@ import static org.apache.ignite.internal.processors.rest.protocols.tcp.redis.Gri
/**
* Redis STRLEN command handler.
*/
-public class GridRedisStrlenCommandHandler extends GridRedisThruRestCommandHandler {
+public class GridRedisStrlenCommandHandler extends GridRedisRestCommandHandler {
/** Supported commands. */
private static final Collection<GridRedisCommand> SUPPORTED_COMMANDS = U.sealList(
STRLEN
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/GridRedisCommand.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/GridRedisCommand.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/GridRedisCommand.java
index 92b77dc..8bcabe2 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/GridRedisCommand.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/GridRedisCommand.java
@@ -19,6 +19,7 @@ package org.apache.ignite.internal.processors.rest.protocols.tcp.redis;
/**
* Supported Redis-specific commands.
+ * See <a href="http://redis.io/commands">Redis commands</a> for details.
* <p>
* Cache operations are handled via REST.
*/
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/GridRedisMessage.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/GridRedisMessage.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/GridRedisMessage.java
index 5974ed0..80c5ffb 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/GridRedisMessage.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/GridRedisMessage.java
@@ -48,7 +48,7 @@ public class GridRedisMessage implements GridClientMessage {
private static final int AUX_OFFSET = 2;
/** Request message parts. */
- private final List<String> msgParts;
+ private transient final List<String> msgParts;
/** Response. */
private ByteBuffer response;
http://git-wip-us.apache.org/repos/asf/ignite/blob/8aa28e26/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/GridRedisProtocolParser.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/GridRedisProtocolParser.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/GridRedisProtocolParser.java
index ea51671..704ae0e 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/GridRedisProtocolParser.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/GridRedisProtocolParser.java
@@ -166,7 +166,7 @@ public class GridRedisProtocolParser {
/**
* @return Standard OK string.
*/
- public static ByteBuffer OkString() {
+ public static ByteBuffer oKString() {
return toSimpleString(OK);
}