[lucenenet] 34/42: Bug: Lucene.Net.TestFramework.JavaCompatibility.SystemTypesHelpers: Overloads of append that take numeric types need to be converted to the invariant culture. Removed the overloads for decimal, double, and float, as those need to be dealt with on a case by case basis.

[ni...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

nightowl888 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucenenet.git

commit 560c8ccae5af9d070537a3f1f66309c5b0ad1f24
Author: Shad Storhaug <sh...@shadstorhaug.com>
AuthorDate: Tue Aug 6 03:43:12 2019 +0700

    Bug: Lucene.Net.TestFramework.JavaCompatibility.SystemTypesHelpers: Overloads of append that take numeric types need to be converted to the invariant culture. Removed the overloads for decimal, double, and float, as those need to be dealt with on a case by case basis.
---
 .../JavaCompatibility/SystemTypesHelpers.cs        | 71 ++++++++++++++--------
 1 file changed, 46 insertions(+), 25 deletions(-)

diff --git a/src/Lucene.Net.TestFramework/JavaCompatibility/SystemTypesHelpers.cs b/src/Lucene.Net.TestFramework/JavaCompatibility/SystemTypesHelpers.cs
index 62f50d9..0cf1daf 100644
--- a/src/Lucene.Net.TestFramework/JavaCompatibility/SystemTypesHelpers.cs
+++ b/src/Lucene.Net.TestFramework/JavaCompatibility/SystemTypesHelpers.cs
@@ -23,6 +23,7 @@ using Lucene.Net.Support;
 using System;
 using System.Collections;
 using System.Collections.Generic;
+using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Reflection;
@@ -91,7 +92,9 @@ namespace Lucene.Net
 
         public static StringBuilder append(this StringBuilder sb, byte value)
         {
-            sb.Append(value);
+            // LUCENENET NOTE: .NET uses the current culture by default, and any
+            // Java code that calls this is expecting invariant culture
+            sb.Append(value.ToString(CultureInfo.InvariantCulture));
             return sb;
         }
 
@@ -107,33 +110,41 @@ namespace Lucene.Net
             return sb;
         }
 
-        public static StringBuilder append(this StringBuilder sb, decimal value)
-        {
-            sb.Append(value);
-            return sb;
-        }
-
-        public static StringBuilder append(this StringBuilder sb, double value)
-        {
-            sb.Append(value);
-            return sb;
-        }
-
-        public static StringBuilder append(this StringBuilder sb, float value)
-        {
-            sb.Append(value);
-            return sb;
-        }
+        // LUCENENET: These would only work if we copied the format from Java,
+        // which is probably not something we want to do anyway.
+        // Instead of calling a centralized method, we should be converting the
+        // code on a case by case basis.
+        //public static StringBuilder append(this StringBuilder sb, decimal value)
+        //{
+        //    sb.Append(value);
+        //    return sb;
+        //}
+
+        //public static StringBuilder append(this StringBuilder sb, double value)
+        //{
+        //    sb.Append(value);
+        //    return sb;
+        //}
+
+        //public static StringBuilder append(this StringBuilder sb, float value)
+        //{
+        //    sb.Append(value);
+        //    return sb;
+        //}
 
         public static StringBuilder append(this StringBuilder sb, int value)
         {
-            sb.Append(value);
+            // LUCENENET NOTE: .NET uses the current culture by default, and any
+            // Java code that calls this is expecting invariant culture
+            sb.Append(value.ToString(CultureInfo.InvariantCulture));
             return sb;
         }
 
         public static StringBuilder append(this StringBuilder sb, long value)
         {
-            sb.Append(value);
+            // LUCENENET NOTE: .NET uses the current culture by default, and any
+            // Java code that calls this is expecting invariant culture
+            sb.Append(value.ToString(CultureInfo.InvariantCulture));
             return sb;
         }
 
@@ -145,13 +156,17 @@ namespace Lucene.Net
 
         public static StringBuilder append(this StringBuilder sb, sbyte value)
         {
-            sb.Append(value);
+            // LUCENENET NOTE: .NET uses the current culture by default, and any
+            // Java code that calls this is expecting invariant culture
+            sb.Append(value.ToString(CultureInfo.InvariantCulture));
             return sb;
         }
 
         public static StringBuilder append(this StringBuilder sb, short value)
         {
-            sb.Append(value);
+            // LUCENENET NOTE: .NET uses the current culture by default, and any
+            // Java code that calls this is expecting invariant culture
+            sb.Append(value.ToString(CultureInfo.InvariantCulture));
             return sb;
         }
 
@@ -163,19 +178,25 @@ namespace Lucene.Net
 
         public static StringBuilder append(this StringBuilder sb, uint value)
         {
-            sb.Append(value);
+            // LUCENENET NOTE: .NET uses the current culture by default, and any
+            // Java code that calls this is expecting invariant culture
+            sb.Append(value.ToString(CultureInfo.InvariantCulture));
             return sb;
         }
 
         public static StringBuilder append(this StringBuilder sb, ulong value)
         {
-            sb.Append(value);
+            // LUCENENET NOTE: .NET uses the current culture by default, and any
+            // Java code that calls this is expecting invariant culture
+            sb.Append(value.ToString(CultureInfo.InvariantCulture));
             return sb;
         }
 
         public static StringBuilder append(this StringBuilder sb, ushort value)
         {
-            sb.Append(value);
+            // LUCENENET NOTE: .NET uses the current culture by default, and any
+            // Java code that calls this is expecting invariant culture
+            sb.Append(value.ToString(CultureInfo.InvariantCulture));
             return sb;
         }