You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/12/04 22:13:17 UTC
Review Request 64316: Messages for some services during PU package
installation indicate circular dependency
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64316/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
Bugs: AMBARI-22590
https://issues.apache.org/jira/browse/AMBARI-22590
Repository: ambari
Description
-------
Written this as 'Blocker' severity, please triage once and decide
This issue could affect user experience for Patch Upgrades
*Case 1:* Register Patch VDF for Mapreduce service
Try to install the packages
Result: Error for missing Hive service in the VDF (see MR-only.png)
*Case 2:* Add Hive to the patch VDF, os that it now includes both MR and Hive
Try to install the packages
Result: Error for missing Tez service in the VDF (see MR-and-Hive)
This is now confusing as the dependency looks cyclic, we asked to add Hive in first case and now asking to add MR again
*Case 3:* Add a new VDF for only Mahout or Oozie. This would prompt for MR due to dependency. Now you need to add MR and Hive and then Tez too (see Mahout-only.png)
*Expected result:* The message for dependent services should recursively decide the services and print them all at once.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/RequiredServicesInRepositoryCheck.java d9114113b2
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java d155d46a58
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java 69e22b37e0
ambari-server/src/test/java/org/apache/ambari/server/checks/RequiredServicesInRepositoryCheckTest.java 59848719ad
ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java 9fe6146a9c
Diff: https://reviews.apache.org/r/64316/diff/1/
Testing
-------
PENDING
Thanks,
Jonathan Hurley
Re: Review Request 64316: Messages for some services during PU package
installation indicate circular dependency
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64316/#review192837
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 5, 2017, 12:13 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64316/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2017, 12:13 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-22590
> https://issues.apache.org/jira/browse/AMBARI-22590
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Written this as 'Blocker' severity, please triage once and decide
>
> This issue could affect user experience for Patch Upgrades
>
> *Case 1:* Register Patch VDF for Mapreduce service
> Try to install the packages
> Result: Error for missing Hive service in the VDF (see MR-only.png)
>
> *Case 2:* Add Hive to the patch VDF, os that it now includes both MR and Hive
> Try to install the packages
> Result: Error for missing Tez service in the VDF (see MR-and-Hive)
>
> This is now confusing as the dependency looks cyclic, we asked to add Hive in first case and now asking to add MR again
>
> *Case 3:* Add a new VDF for only Mahout or Oozie. This would prompt for MR due to dependency. Now you need to add MR and Hive and then Tez too (see Mahout-only.png)
>
> *Expected result:* The message for dependent services should recursively decide the services and print them all at once.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/RequiredServicesInRepositoryCheck.java d9114113b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java d155d46a58
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java 69e22b37e0
> ambari-server/src/test/java/org/apache/ambari/server/checks/RequiredServicesInRepositoryCheckTest.java 59848719ad
> ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java 9fe6146a9c
>
>
> Diff: https://reviews.apache.org/r/64316/diff/2/
>
>
> Testing
> -------
>
> PENDING
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 64316: Messages for some services during PU package
installation indicate circular dependency
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64316/#review192866
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Dec. 4, 2017, 5:13 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64316/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2017, 5:13 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-22590
> https://issues.apache.org/jira/browse/AMBARI-22590
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Written this as 'Blocker' severity, please triage once and decide
>
> This issue could affect user experience for Patch Upgrades
>
> *Case 1:* Register Patch VDF for Mapreduce service
> Try to install the packages
> Result: Error for missing Hive service in the VDF (see MR-only.png)
>
> *Case 2:* Add Hive to the patch VDF, os that it now includes both MR and Hive
> Try to install the packages
> Result: Error for missing Tez service in the VDF (see MR-and-Hive)
>
> This is now confusing as the dependency looks cyclic, we asked to add Hive in first case and now asking to add MR again
>
> *Case 3:* Add a new VDF for only Mahout or Oozie. This would prompt for MR due to dependency. Now you need to add MR and Hive and then Tez too (see Mahout-only.png)
>
> *Expected result:* The message for dependent services should recursively decide the services and print them all at once.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/RequiredServicesInRepositoryCheck.java d9114113b2
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java d155d46a58
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java 69e22b37e0
> ambari-server/src/test/java/org/apache/ambari/server/checks/RequiredServicesInRepositoryCheckTest.java 59848719ad
> ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java 9fe6146a9c
>
>
> Diff: https://reviews.apache.org/r/64316/diff/2/
>
>
> Testing
> -------
>
> PENDING
>
>
> Thanks,
>
> Jonathan Hurley
>
>